# HG changeset patch # User Ralph Meijer # Date 1114363167 0 # Node ID ffc3c706b0fb2b02723f9531d263e1dd374f4972 # Parent 0d7b95fb2549e03fffd4a92f2aacabbe848597a5 Don't return anything when removing items, and raise exception when an item is not found. Return items for get_items() in unicode string. diff -r 0d7b95fb2549 -r ffc3c706b0fb idavoll/memory_storage.py --- a/idavoll/memory_storage.py Tue Apr 12 14:51:59 2005 +0000 +++ b/idavoll/memory_storage.py Sun Apr 24 17:19:27 2005 +0000 @@ -161,22 +161,22 @@ deleted = [] for item_id in item_ids: - try: - item = self._items[item_id] - self._itemlist.remove(item) - del self._items[item_id] - deleted.append(item_id) - except KeyError: - pass + if not self._items.has_key(item_id): + return defer.fail(storage.ItemNotFound()) + + for item_id in item_ids: + item = self._items[item_id] + self._itemlist.remove(item) + del self._items[item_id] - return defer.succeed(deleted) + return defer.succeed(None) def get_items(self, max_items=None): if max_items: list = self._itemlist[-max_items:] else: list = self._itemlist - return defer.succeed([item[0] for item in list]) + return defer.succeed([unicode(item[0], 'utf-8') for item in list]) def get_items_by_id(self, item_ids): items = [] @@ -186,7 +186,7 @@ except KeyError: pass else: - items.append(item[0]) + items.append(unicode(item[0], 'utf-8')) return defer.succeed(items) def purge(self):