Mercurial > libervia-backend

comparison sat/bridge/bridge_constructor/constructors/pb/constructor.py @ 4037:524856bd7b19

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
massive refactoring to switch from camelCase to snake_case: historically, Libervia (SàT before) was using camelCase as allowed by PEP8 when using a pre-PEP8 code, to use the same coding style as in Twisted. However, snake_case is more readable and it's better to follow PEP8 best practices, so it has been decided to move on full snake_case. Because Libervia has a huge codebase, this ended with a ugly mix of camelCase and snake_case. To fix that, this patch does a big refactoring by renaming every function and method (including bridge) that are not coming from Twisted or Wokkel, to use fully snake_case. This is a massive change, and may result in some bugs.
author Goffi <goffi@goffi.org>
date Sat, 08 Apr 2023 13:54:42 +0200
parents 7550ae9cfbac
children
comparison
equal deleted inserted replaced
4036:c4464d7ae97b 4037:524856bd7b19
24 CORE_TEMPLATE = "pb_core_template.py" 24 CORE_TEMPLATE = "pb_core_template.py"
25 CORE_DEST = "pb.py" 25 CORE_DEST = "pb.py"
26 CORE_FORMATS = { 26 CORE_FORMATS = {
27 "signals": """\ 27 "signals": """\
28 def {name}(self, {args}): 28 def {name}(self, {args}):
29 {debug}self.sendSignal("{name}", {args_no_def})\n""" 29 {debug}self.send_signal("{name}", {args_no_def})\n"""
30 } 30 }
31 31
32 FRONTEND_TEMPLATE = "pb_frontend_template.py" 32 FRONTEND_TEMPLATE = "pb_frontend_template.py"
33 FRONTEND_DEST = CORE_DEST 33 FRONTEND_DEST = CORE_DEST
34 FRONTEND_FORMATS = { 34 FRONTEND_FORMATS = {
47 d.addErrback(self._errback) 47 d.addErrback(self._errback)
48 return d.asFuture(asyncio.get_event_loop())\n""", 48 return d.asFuture(asyncio.get_event_loop())\n""",
49 } 49 }
50 50
51 def core_completion_signal(self, completion, function, default, arg_doc, async_): 51 def core_completion_signal(self, completion, function, default, arg_doc, async_):
52 completion["args_no_def"] = self.getArguments(function["sig_in"], name=arg_doc) 52 completion["args_no_def"] = self.get_arguments(function["sig_in"], name=arg_doc)
53 completion["debug"] = ( 53 completion["debug"] = (
54 "" 54 ""
55 if not self.args.debug 55 if not self.args.debug
56 else 'log.debug ("%s")\n%s' % (completion["name"], 8 * " ") 56 else 'log.debug ("%s")\n%s' % (completion["name"], 8 * " ")
57 ) 57 )
58 58
59 def frontend_completion_method(self, completion, function, default, arg_doc, async_): 59 def frontend_completion_method(self, completion, function, default, arg_doc, async_):
60 completion.update( 60 completion.update(
61 { 61 {
62 "args_comma": ", " if function["sig_in"] else "", 62 "args_comma": ", " if function["sig_in"] else "",
63 "args_no_def": self.getArguments(function["sig_in"], name=arg_doc), 63 "args_no_def": self.get_arguments(function["sig_in"], name=arg_doc),
64 "callback": "callback" 64 "callback": "callback"
65 if function["sig_out"] 65 if function["sig_out"]
66 else "lambda __: callback()", 66 else "lambda __: callback()",
67 "debug": "" 67 "debug": ""
68 if not self.args.debug 68 if not self.args.debug