Mercurial > libervia-backend
comparison sat/plugins/plugin_misc_welcome.py @ 4037:524856bd7b19
massive refactoring to switch from camelCase to snake_case:
historically, Libervia (SàT before) was using camelCase as allowed by PEP8 when using a
pre-PEP8 code, to use the same coding style as in Twisted.
However, snake_case is more readable and it's better to follow PEP8 best practices, so it
has been decided to move on full snake_case. Because Libervia has a huge codebase, this
ended with a ugly mix of camelCase and snake_case.
To fix that, this patch does a big refactoring by renaming every function and method
(including bridge) that are not coming from Twisted or Wokkel, to use fully snake_case.
This is a massive change, and may result in some bugs.
author | Goffi <goffi@goffi.org> |
---|---|
date | Sat, 08 Apr 2023 13:54:42 +0200 |
parents | be6d91572633 |
children |
comparison
equal
deleted
inserted
replaced
4036:c4464d7ae97b | 4037:524856bd7b19 |
---|---|
72 | 72 |
73 class Welcome(object): | 73 class Welcome(object): |
74 def __init__(self, host): | 74 def __init__(self, host): |
75 log.info(_("plugin Welcome initialization")) | 75 log.info(_("plugin Welcome initialization")) |
76 self.host = host | 76 self.host = host |
77 host.memory.updateParams(PARAMS) | 77 host.memory.update_params(PARAMS) |
78 | 78 |
79 def profileConnected(self, client): | 79 def profile_connected(self, client): |
80 # XXX: if you wan to try first_start again, you'll have to remove manually | 80 # XXX: if you wan to try first_start again, you'll have to remove manually |
81 # the welcome value from your profile params in sat.db | 81 # the welcome value from your profile params in sat.db |
82 welcome = self.host.memory.params.getParamA( | 82 welcome = self.host.memory.params.param_get_a( |
83 WELCOME_PARAM_NAME, | 83 WELCOME_PARAM_NAME, |
84 WELCOME_PARAM_CATEGORY, | 84 WELCOME_PARAM_CATEGORY, |
85 use_default=False, | 85 use_default=False, |
86 profile_key=client.profile, | 86 profile_key=client.profile, |
87 ) | 87 ) |
91 else: | 91 else: |
92 first_start = False | 92 first_start = False |
93 | 93 |
94 if welcome: | 94 if welcome: |
95 xmlui = xml_tools.note(WELCOME_MSG, WELCOME_MSG_TITLE) | 95 xmlui = xml_tools.note(WELCOME_MSG, WELCOME_MSG_TITLE) |
96 self.host.actionNew({"xmlui": xmlui.toXml()}, profile=client.profile) | 96 self.host.action_new({"xmlui": xmlui.toXml()}, profile=client.profile) |
97 self.host.memory.setParam( | 97 self.host.memory.param_set( |
98 WELCOME_PARAM_NAME, | 98 WELCOME_PARAM_NAME, |
99 C.BOOL_FALSE, | 99 C.BOOL_FALSE, |
100 WELCOME_PARAM_CATEGORY, | 100 WELCOME_PARAM_CATEGORY, |
101 profile_key=client.profile, | 101 profile_key=client.profile, |
102 ) | 102 ) |