Mercurial > libervia-backend
comparison sat/test/test_core_xmpp.py @ 4037:524856bd7b19
massive refactoring to switch from camelCase to snake_case:
historically, Libervia (SàT before) was using camelCase as allowed by PEP8 when using a
pre-PEP8 code, to use the same coding style as in Twisted.
However, snake_case is more readable and it's better to follow PEP8 best practices, so it
has been decided to move on full snake_case. Because Libervia has a huge codebase, this
ended with a ugly mix of camelCase and snake_case.
To fix that, this patch does a big refactoring by renaming every function and method
(including bridge) that are not coming from Twisted or Wokkel, to use fully snake_case.
This is a massive change, and may result in some bugs.
author | Goffi <goffi@goffi.org> |
---|---|
date | Sat, 08 Apr 2023 13:54:42 +0200 |
parents | be6d91572633 |
children |
comparison
equal
deleted
inserted
replaced
4036:c4464d7ae97b | 4037:524856bd7b19 |
---|---|
44 def setUp(self): | 44 def setUp(self): |
45 self.host = helpers.FakeSAT() | 45 self.host = helpers.FakeSAT() |
46 self.message = xmpp.SatMessageProtocol(self.host) | 46 self.message = xmpp.SatMessageProtocol(self.host) |
47 self.message.parent = helpers.FakeClient(self.host) | 47 self.message.parent = helpers.FakeClient(self.host) |
48 | 48 |
49 def test_onMessage(self): | 49 def test_on_message(self): |
50 xml = """ | 50 xml = """ |
51 <message type="chat" from="sender@example.net/house" to="test@example.org/SàT" id="test_1"> | 51 <message type="chat" from="sender@example.net/house" to="test@example.org/SàT" id="test_1"> |
52 <body>test</body> | 52 <body>test</body> |
53 </message> | 53 </message> |
54 """ | 54 """ |
55 stanza = parseXml(xml) | 55 stanza = parseXml(xml) |
56 self.host.bridge.expectCall("messageNew", "sender@example.net/house", "test", "chat", "test@example.org/SàT", {}, profile=Const.PROFILE[0]) | 56 self.host.bridge.expect_call("message_new", "sender@example.net/house", "test", "chat", "test@example.org/SàT", {}, profile=Const.PROFILE[0]) |
57 self.message.onMessage(stanza) | 57 self.message.onMessage(stanza) |
58 | 58 |
59 | 59 |
60 class SatRosterProtocolTest(unittest.TestCase): | 60 class SatRosterProtocolTest(unittest.TestCase): |
61 | 61 |
62 def setUp(self): | 62 def setUp(self): |
63 self.host = helpers.FakeSAT() | 63 self.host = helpers.FakeSAT() |
64 self.roster = xmpp.SatRosterProtocol(self.host) | 64 self.roster = xmpp.SatRosterProtocol(self.host) |
65 self.roster.parent = helpers.FakeClient(self.host) | 65 self.roster.parent = helpers.FakeClient(self.host) |
66 | 66 |
67 def test__registerItem(self): | 67 def test_register_item(self): |
68 roster_item = RosterItem(Const.JID[0]) | 68 roster_item = RosterItem(Const.JID[0]) |
69 roster_item.name = "Test Man" | 69 roster_item.name = "Test Man" |
70 roster_item.subscriptionTo = True | 70 roster_item.subscriptionTo = True |
71 roster_item.subscriptionFrom = True | 71 roster_item.subscriptionFrom = True |
72 roster_item.ask = False | 72 roster_item.ask = False |
73 roster_item.groups = set(["Test Group 1", "Test Group 2", "Test Group 3"]) | 73 roster_item.groups = set(["Test Group 1", "Test Group 2", "Test Group 3"]) |
74 self.host.bridge.expectCall("newContact", Const.JID_STR[0], {'to': 'True', 'from': 'True', 'ask': 'False', 'name': 'Test Man'}, set(["Test Group 1", "Test Group 2", "Test Group 3"]), Const.PROFILE[0]) | 74 self.host.bridge.expect_call("contact_new", Const.JID_STR[0], {'to': 'True', 'from': 'True', 'ask': 'False', 'name': 'Test Man'}, set(["Test Group 1", "Test Group 2", "Test Group 3"]), Const.PROFILE[0]) |
75 self.roster._registerItem(roster_item) | 75 self.roster._register_item(roster_item) |
76 | 76 |
77 | 77 |
78 class SatPresenceProtocolTest(unittest.TestCase): | 78 class SatPresenceProtocolTest(unittest.TestCase): |
79 | 79 |
80 def setUp(self): | 80 def setUp(self): |
81 self.host = helpers.FakeSAT() | 81 self.host = helpers.FakeSAT() |
82 self.presence = xmpp.SatPresenceProtocol(self.host) | 82 self.presence = xmpp.SatPresenceProtocol(self.host) |
83 self.presence.parent = helpers.FakeClient(self.host) | 83 self.presence.parent = helpers.FakeClient(self.host) |
84 | 84 |
85 def test_availableReceived(self): | 85 def test_availableReceived(self): |
86 self.host.bridge.expectCall("presenceUpdate", Const.JID_STR[0], "xa", 15, {'default': "test status", 'fr': 'statut de test'}, Const.PROFILE[0]) | 86 self.host.bridge.expect_call("presence_update", Const.JID_STR[0], "xa", 15, {'default': "test status", 'fr': 'statut de test'}, Const.PROFILE[0]) |
87 self.presence.availableReceived(Const.JID[0], 'xa', {None: "test status", 'fr': 'statut de test'}, 15) | 87 self.presence.availableReceived(Const.JID[0], 'xa', {None: "test status", 'fr': 'statut de test'}, 15) |
88 | 88 |
89 def test_availableReceived_empty_statuses(self): | 89 def test_available_received_empty_statuses(self): |
90 self.host.bridge.expectCall("presenceUpdate", Const.JID_STR[0], "xa", 15, {}, Const.PROFILE[0]) | 90 self.host.bridge.expect_call("presence_update", Const.JID_STR[0], "xa", 15, {}, Const.PROFILE[0]) |
91 self.presence.availableReceived(Const.JID[0], 'xa', None, 15) | 91 self.presence.availableReceived(Const.JID[0], 'xa', None, 15) |
92 | 92 |
93 def test_unavailableReceived(self): | 93 def test_unavailableReceived(self): |
94 self.host.bridge.expectCall("presenceUpdate", Const.JID_STR[0], "unavailable", 0, {}, Const.PROFILE[0]) | 94 self.host.bridge.expect_call("presence_update", Const.JID_STR[0], "unavailable", 0, {}, Const.PROFILE[0]) |
95 self.presence.unavailableReceived(Const.JID[0], None) | 95 self.presence.unavailableReceived(Const.JID[0], None) |
96 | 96 |
97 def test_subscribedReceived(self): | 97 def test_subscribedReceived(self): |
98 self.host.bridge.expectCall("subscribe", "subscribed", Const.JID[0].userhost(), Const.PROFILE[0]) | 98 self.host.bridge.expect_call("subscribe", "subscribed", Const.JID[0].userhost(), Const.PROFILE[0]) |
99 self.presence.subscribedReceived(Const.JID[0]) | 99 self.presence.subscribedReceived(Const.JID[0]) |
100 | 100 |
101 def test_unsubscribedReceived(self): | 101 def test_unsubscribedReceived(self): |
102 self.host.bridge.expectCall("subscribe", "unsubscribed", Const.JID[0].userhost(), Const.PROFILE[0]) | 102 self.host.bridge.expect_call("subscribe", "unsubscribed", Const.JID[0].userhost(), Const.PROFILE[0]) |
103 self.presence.unsubscribedReceived(Const.JID[0]) | 103 self.presence.unsubscribedReceived(Const.JID[0]) |
104 | 104 |
105 def test_subscribeReceived(self): | 105 def test_subscribeReceived(self): |
106 self.host.bridge.expectCall("subscribe", "subscribe", Const.JID[0].userhost(), Const.PROFILE[0]) | 106 self.host.bridge.expect_call("subscribe", "subscribe", Const.JID[0].userhost(), Const.PROFILE[0]) |
107 self.presence.subscribeReceived(Const.JID[0]) | 107 self.presence.subscribeReceived(Const.JID[0]) |
108 | 108 |
109 def test_unsubscribeReceived(self): | 109 def test_unsubscribeReceived(self): |
110 self.host.bridge.expectCall("subscribe", "unsubscribe", Const.JID[0].userhost(), Const.PROFILE[0]) | 110 self.host.bridge.expect_call("subscribe", "unsubscribe", Const.JID[0].userhost(), Const.PROFILE[0]) |
111 self.presence.unsubscribeReceived(Const.JID[0]) | 111 self.presence.unsubscribeReceived(Const.JID[0]) |