Mercurial > libervia-backend
comparison sat_frontends/jp/cmd_identity.py @ 4037:524856bd7b19
massive refactoring to switch from camelCase to snake_case:
historically, Libervia (SàT before) was using camelCase as allowed by PEP8 when using a
pre-PEP8 code, to use the same coding style as in Twisted.
However, snake_case is more readable and it's better to follow PEP8 best practices, so it
has been decided to move on full snake_case. Because Libervia has a huge codebase, this
ended with a ugly mix of camelCase and snake_case.
To fix that, this patch does a big refactoring by renaming every function and method
(including bridge) that are not coming from Twisted or Wokkel, to use fully snake_case.
This is a massive change, and may result in some bugs.
| author | Goffi <goffi@goffi.org> |
|---|---|
| date | Sat, 08 Apr 2023 13:54:42 +0200 |
| parents | 10a4846818e5 |
| children | 4b842c1fb686 |
comparison
equal
deleted
inserted
replaced
| 4036:c4464d7ae97b | 4037:524856bd7b19 |
|---|---|
| 46 ) | 46 ) |
| 47 | 47 |
| 48 async def start(self): | 48 async def start(self): |
| 49 jid_ = (await self.host.check_jids([self.args.jid]))[0] | 49 jid_ = (await self.host.check_jids([self.args.jid]))[0] |
| 50 try: | 50 try: |
| 51 data = await self.host.bridge.identityGet( | 51 data = await self.host.bridge.identity_get( |
| 52 jid_, | 52 jid_, |
| 53 [], | 53 [], |
| 54 not self.args.no_cache, | 54 not self.args.no_cache, |
| 55 self.profile | 55 self.profile |
| 56 ) | 56 ) |
| 89 if value is not None: | 89 if value is not None: |
| 90 id_data[field] = value | 90 id_data[field] = value |
| 91 if not id_data: | 91 if not id_data: |
| 92 self.parser.error("At least one metadata must be set") | 92 self.parser.error("At least one metadata must be set") |
| 93 try: | 93 try: |
| 94 self.host.bridge.identitySet( | 94 self.host.bridge.identity_set( |
| 95 data_format.serialise(id_data), | 95 data_format.serialise(id_data), |
| 96 self.profile, | 96 self.profile, |
| 97 ) | 97 ) |
| 98 except Exception as e: | 98 except Exception as e: |
| 99 self.disp(f"can't set identity data: {e}", error=True) | 99 self.disp(f"can't set identity data: {e}", error=True) |