libervia-backend: libervia/backend/core/main.py comparison

core: show warning instead of exception in case of missing dependency when loading plugins

comparison

equal deleted inserted replaced

-:4cf98f506269
+:9e63e02318ec
 )
 continue
 plugin_path = f"libervia.backend.plugins.{plug_name}"
 try:
 __import__(plugin_path)
-except exceptions.MissingModule as e:
+except (ModuleNotFoundError, exceptions.MissingModule) as e:
 self._unimport_plugin(plugin_path)
 log.warning(
 "Can't import plugin [{path}] because of an unavailale third party "
 "module:\n{msg}".format(path=plugin_path, msg=e)
 )
 raise e
 log.info("importing plugin: {}".format(plugin_info["name"]))
 # we instanciate the plugin here
 try:
 self.plugins[import_name] = getattr(mod, plugin_info["main"])(self)
-except Exception as e:
+except (exceptions.NotFound, Exception) as e:
-log.exception(
+if isinstance(e, exceptions.NotFound):
-f"Can't load plugin \"{plugin_info['name']}\", ignoring it: {e}"
+# A warning is enough for a missing dependency.
-)
+log.warning(
+f"Can't load plugin \"{plugin_info['name']}\", due to missing "
+f"dependency, ignoring it: {e}"
+)
+else:
+log.exception(
+f"Can't load plugin \"{plugin_info['name']}\", ignoring it"
+)
 if optional:
 return
 raise ImportError("Error during initiation")
 if C.bool(plugin_info.get(C.PI_HANDLER, C.BOOL_FALSE)):
 self.plugins[import_name].is_handler = True

Mercurial > libervia-backend