comparison libervia/backend/plugins/plugin_xep_0391.py @ 4231:e11b13418ba6

plugin XEP-0353, XEP-0234, jingle: WebRTC data channel signaling implementation: Implement XEP-0343: Signaling WebRTC Data Channels in Jingle. The current version of the XEP (0.3.1) has no implementation and contains some flaws. After discussing this on xsf@, Daniel (from Conversations) mentioned that they had a sprint with Larma (from Dino) to work on another version and provided me with this link: https://gist.github.com/iNPUTmice/6c56f3e948cca517c5fb129016d99e74 . I have used it for my implementation. This implementation reuses work done on Jingle A/V call (notably XEP-0176 and XEP-0167 plugins), with adaptations. When used, XEP-0234 will not handle the file itself as it normally does. This is because WebRTC has several implementations (browser for web interface, GStreamer for others), and file/data must be handled directly by the frontend. This is particularly important for web frontends, as the file is not sent from the backend but from the end-user's browser device. Among the changes, there are: - XEP-0343 implementation. - `file_send` bridge method now use serialised dict as output. - New `BaseTransportHandler.is_usable` method which get content data and returns a boolean (default to `True`) to tell if this transport can actually be used in this context (when we are initiator). Used in webRTC case to see if call data are available. - Support of `application` media type, and everything necessary to handle data channels. - Better confirmation message, with file name, size and description when available. - When file is accepted in preflight, it is specified in following `action_new` signal for actual file transfer. This way, frontend can avoid the display or 2 confirmation messages. - XEP-0166: when not specified, default `content` name is now its index number instead of a UUID. This follows the behaviour of browsers. - XEP-0353: better handling of events such as call taken by another device. - various other updates. rel 441
author Goffi <goffi@goffi.org>
date Sat, 06 Apr 2024 12:57:23 +0200
parents 919bdf7768d8
children 0d7bb4df2343
comparison
equal deleted inserted replaced
4230:314d3c02bb67 4231:e11b13418ba6
108 session["peer_jid"].userhostJID() 108 session["peer_jid"].userhostJID()
109 ) != self._o.NS_OLDMEMO: 109 ) != self._o.NS_OLDMEMO:
110 return True 110 return True
111 for content_elt in jingle_elt.elements(self._j.namespace, "content"): 111 for content_elt in jingle_elt.elements(self._j.namespace, "content"):
112 content_data = session["contents"][content_elt["name"]] 112 content_data = session["contents"][content_elt["name"]]
113 transport_data = content_data["transport_data"]
114 if transport_data.get("webrtc"):
115 # webRTC is already e2e encrypted, we skip this content to avoid double
116 # encryption
117 continue
113 security_elt = content_elt.addElement((NS_JET, "security")) 118 security_elt = content_elt.addElement((NS_JET, "security"))
114 security_elt["name"] = content_elt["name"] 119 security_elt["name"] = content_elt["name"]
115 # XXX: for now only OLDMEMO is supported, thus we do it directly here. If some 120 # XXX: for now only OLDMEMO is supported, thus we do it directly here. If some
116 # other are supported in the future, a plugin registering mechanism will be 121 # other are supported in the future, a plugin registering mechanism will be
117 # implemented. 122 # implemented.
242 client: SatXMPPEntity, 247 client: SatXMPPEntity,
243 session: Dict[str, Any], 248 session: Dict[str, Any],
244 content_data: Dict[str, Any], 249 content_data: Dict[str, Any],
245 elt: domish.Element 250 elt: domish.Element
246 ) -> bool: 251 ) -> bool:
247 file_obj = content_data["stream_object"].file_obj 252 try:
253 file_obj = content_data["stream_object"].file_obj
254 except KeyError:
255 transport_data = content_data["transport_data"]
256 if transport_data.get("webrtc"):
257 # we skip JET to avoid double encryption
258 log.debug("JET skipped due to webrtc transport.")
259 return True
248 try: 260 try:
249 encryption_data=content_data["encryption"] 261 encryption_data=content_data["encryption"]
250 except KeyError: 262 except KeyError:
251 return True 263 return True
252 cipher = ciphers.Cipher( 264 cipher = ciphers.Cipher(