Mercurial > libervia-backend

diff sat/plugins/plugin_misc_attach.py @ 3859:3ef988734869

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
core: fix calls to `domish.Element.elements`: domish.Element.elements should be called with namespace and element name as 2 arguments, but it has been confused in several places with the call to `domish.Element.addElement` which is often done with a `(namespace, name)` tuple. Unfortunately calling with a tuple is accepted and doesn't raise any error in `elements`, but this result in a wrong element returned. This patch fixes the erroneous calls.
author Goffi <goffi@goffi.org>
date Wed, 20 Jul 2022 17:12:29 +0200
parents be6d91572633
children 0ff265725489
line wrap: on
line diff
--- a/sat/plugins/plugin_misc_attach.py	Thu Jul 14 12:55:30 2022 +0200
+++ b/sat/plugins/plugin_misc_attach.py	Wed Jul 20 17:12:29 2022 +0200
@@ -248,7 +248,7 @@
     async def defaultAttach(self, client, data):
         await self.uploadFiles(client, data)
         # TODO: handle xhtml-im
-        body_elt = next(data["xml"].elements((C.NS_CLIENT, "body")))
+        body_elt = next(data["xml"].elements(C.NS_CLIENT, "body"))
         attachments = data["extra"][C.MESS_KEY_ATTACHMENTS]
         if attachments:
             body_links = '\n'.join(a['url'] for a in attachments)