diff sat/plugins/plugin_xep_0234.py @ 3859:3ef988734869

core: fix calls to `domish.Element.elements`: domish.Element.elements should be called with namespace and element name as 2 arguments, but it has been confused in several places with the call to `domish.Element.addElement` which is often done with a `(namespace, name)` tuple. Unfortunately calling with a tuple is accepted and doesn't raise any error in `elements`, but this result in a wrong element returned. This patch fixes the erroneous calls.
author Goffi <goffi@goffi.org>
date Wed, 20 Jul 2022 17:12:29 +0200
parents bbf92ef05f38
children 8e7d5796fb23
line wrap: on
line diff
--- a/sat/plugins/plugin_xep_0234.py	Thu Jul 14 12:55:30 2022 +0200
+++ b/sat/plugins/plugin_xep_0234.py	Wed Jul 20 17:12:29 2022 +0200
@@ -667,7 +667,7 @@
                     return
                 file_data = content_data["application_data"]["file_data"]
                 try:
-                    file_elt = next(elt.elements((NS_JINGLE_FT, "file")))
+                    file_elt = next(elt.elements(NS_JINGLE_FT, "file"))
                 except StopIteration:
                     raise exceptions.DataError
                 algo, file_data["given_file_hash"] = self._hash.parseHashElt(file_elt)