Mercurial > libervia-backend
diff sat/plugins/plugin_xep_0346.py @ 3859:3ef988734869
core: fix calls to `domish.Element.elements`:
domish.Element.elements should be called with namespace and element name as 2 arguments,
but it has been confused in several places with the call to `domish.Element.addElement`
which is often done with a `(namespace, name)` tuple. Unfortunately calling with a tuple
is accepted and doesn't raise any error in `elements`, but this result in a wrong element
returned.
This patch fixes the erroneous calls.
author | Goffi <goffi@goffi.org> |
---|---|
date | Wed, 20 Jul 2022 17:12:29 +0200 |
parents | 909b56b115ff |
children | 524856bd7b19 |
line wrap: on
line diff
--- a/sat/plugins/plugin_xep_0346.py Thu Jul 14 12:55:30 2022 +0200 +++ b/sat/plugins/plugin_xep_0346.py Wed Jul 20 17:12:29 2022 +0200 @@ -372,7 +372,7 @@ items, metadata = items_data items_xmlui = [] for item_elt in items: - for x_elt in item_elt.elements((data_form.NS_X_DATA, "x")): + for x_elt in item_elt.elements(data_form.NS_X_DATA, "x"): form = data_form.Form.fromElement(x_elt) if form_ns and form.formNamespace != form_ns: log.debug(