Mercurial > libervia-backend

diff sat/plugins/plugin_misc_watched.py @ 4037:524856bd7b19

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
massive refactoring to switch from camelCase to snake_case: historically, Libervia (SàT before) was using camelCase as allowed by PEP8 when using a pre-PEP8 code, to use the same coding style as in Twisted. However, snake_case is more readable and it's better to follow PEP8 best practices, so it has been decided to move on full snake_case. Because Libervia has a huge codebase, this ended with a ugly mix of camelCase and snake_case. To fix that, this patch does a big refactoring by renaming every function and method (including bridge) that are not coming from Twisted or Wokkel, to use fully snake_case. This is a massive change, and may result in some bugs.
author Goffi <goffi@goffi.org>
date Sat, 08 Apr 2023 13:54:42 +0200
parents be6d91572633
children
line wrap: on
line diff
--- a/sat/plugins/plugin_misc_watched.py	Fri Apr 07 15:18:39 2023 +0200
+++ b/sat/plugins/plugin_misc_watched.py	Sat Apr 08 13:54:42 2023 +0200
@@ -61,25 +61,25 @@
     def __init__(self, host):
         log.info(_("Watched initialisation"))
         self.host = host
-        host.memory.updateParams(self.params)
-        host.trigger.add("presence_received", self._presenceReceivedTrigger)
+        host.memory.update_params(self.params)
+        host.trigger.add("presence_received", self._presence_received_trigger)
 
-    def _presenceReceivedTrigger(self, client, entity, show, priority, statuses):
+    def _presence_received_trigger(self, client, entity, show, priority, statuses):
         if show == C.PRESENCE_UNAVAILABLE:
             return True
 
         # we check that the previous presence was unavailable (no notification else)
         try:
-            old_show = self.host.memory.getEntityDatum(
+            old_show = self.host.memory.get_entity_datum(
                 client, entity, "presence").show
         except (KeyError, exceptions.UnknownEntityError):
             old_show = C.PRESENCE_UNAVAILABLE
 
         if old_show == C.PRESENCE_UNAVAILABLE:
-            watched = self.host.memory.getParamA(
+            watched = self.host.memory.param_get_a(
                 NAME, CATEGORY, profile_key=client.profile)
             if entity in watched or entity.userhostJID() in watched:
-                self.host.actionNew(
+                self.host.action_new(
                     {
                         "xmlui": xml_tools.note(
                             _(NOTIF).format(entity=entity.full())