Mercurial > libervia-backend

diff sat/plugins/plugin_misc_welcome.py @ 4037:524856bd7b19

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
massive refactoring to switch from camelCase to snake_case: historically, Libervia (SàT before) was using camelCase as allowed by PEP8 when using a pre-PEP8 code, to use the same coding style as in Twisted. However, snake_case is more readable and it's better to follow PEP8 best practices, so it has been decided to move on full snake_case. Because Libervia has a huge codebase, this ended with a ugly mix of camelCase and snake_case. To fix that, this patch does a big refactoring by renaming every function and method (including bridge) that are not coming from Twisted or Wokkel, to use fully snake_case. This is a massive change, and may result in some bugs.
author Goffi <goffi@goffi.org>
date Sat, 08 Apr 2023 13:54:42 +0200
parents be6d91572633
children
line wrap: on
line diff
--- a/sat/plugins/plugin_misc_welcome.py	Fri Apr 07 15:18:39 2023 +0200
+++ b/sat/plugins/plugin_misc_welcome.py	Sat Apr 08 13:54:42 2023 +0200
@@ -74,12 +74,12 @@
     def __init__(self, host):
         log.info(_("plugin Welcome initialization"))
         self.host = host
-        host.memory.updateParams(PARAMS)
+        host.memory.update_params(PARAMS)
 
-    def profileConnected(self, client):
+    def profile_connected(self, client):
         # XXX: if you wan to try first_start again, you'll have to remove manually
         #      the welcome value from your profile params in sat.db
-        welcome = self.host.memory.params.getParamA(
+        welcome = self.host.memory.params.param_get_a(
             WELCOME_PARAM_NAME,
             WELCOME_PARAM_CATEGORY,
             use_default=False,
@@ -93,8 +93,8 @@
 
         if welcome:
             xmlui = xml_tools.note(WELCOME_MSG, WELCOME_MSG_TITLE)
-            self.host.actionNew({"xmlui": xmlui.toXml()}, profile=client.profile)
-            self.host.memory.setParam(
+            self.host.action_new({"xmlui": xmlui.toXml()}, profile=client.profile)
+            self.host.memory.param_set(
                 WELCOME_PARAM_NAME,
                 C.BOOL_FALSE,
                 WELCOME_PARAM_CATEGORY,