Mercurial > libervia-backend
diff sat/test/test_plugin_xep_0334.py @ 4037:524856bd7b19
massive refactoring to switch from camelCase to snake_case:
historically, Libervia (SàT before) was using camelCase as allowed by PEP8 when using a
pre-PEP8 code, to use the same coding style as in Twisted.
However, snake_case is more readable and it's better to follow PEP8 best practices, so it
has been decided to move on full snake_case. Because Libervia has a huge codebase, this
ended with a ugly mix of camelCase and snake_case.
To fix that, this patch does a big refactoring by renaming every function and method
(including bridge) that are not coming from Twisted or Wokkel, to use fully snake_case.
This is a massive change, and may result in some bugs.
| author | Goffi <goffi@goffi.org> |
|---|---|
| date | Sat, 08 Apr 2023 13:54:42 +0200 |
| parents | be6d91572633 |
| children |
line wrap: on
line diff
--- a/sat/test/test_plugin_xep_0334.py Fri Apr 07 15:18:39 2023 +0200 +++ b/sat/test/test_plugin_xep_0334.py Sat Apr 08 13:54:42 2023 +0200 @@ -35,7 +35,7 @@ self.host = helpers.FakeSAT() self.plugin = XEP_0334(self.host) - def test_messageSendTrigger(self): + def test_message_send_trigger(self): template_xml = """ <message from='romeo@montague.net/orchard' @@ -51,7 +51,7 @@ def cb(data, expected_xml): result_xml = data["xml"].toXml().encode("utf-8") - self.assertEqualXML(result_xml, expected_xml, True) + self.assert_equal_xml(result_xml, expected_xml, True) for key in HINTS + ("", "dummy_hint"): mess_data = { @@ -60,7 +60,7 @@ } treatments = defer.Deferred() self.plugin.messageSendTrigger( - self.host.getClient(C.PROFILE[0]), mess_data, defer.Deferred(), treatments + self.host.get_client(C.PROFILE[0]), mess_data, defer.Deferred(), treatments ) if treatments.callbacks: # the trigger added a callback expected_xml = template_xml % ('<%s xmlns="urn:xmpp:hints"/>' % key) @@ -70,7 +70,7 @@ return defer.DeferredList(d_list) - def test_messageReceivedTrigger(self): + def test_message_received_trigger(self): template_xml = """ <message from='romeo@montague.net/orchard' @@ -92,8 +92,8 @@ for key in HINTS + ("dummy_hint",): message = parseXml(template_xml % ('<%s xmlns="urn:xmpp:hints"/>' % key)) post_treat = defer.Deferred() - self.plugin.messageReceivedTrigger( - self.host.getClient(C.PROFILE[0]), message, post_treat + self.plugin.message_received_trigger( + self.host.get_client(C.PROFILE[0]), message, post_treat ) if post_treat.callbacks: assert key in ("no-permanent-storage", "no-storage")