Mercurial > libervia-backend
diff sat_frontends/jp/cmd_adhoc.py @ 4037:524856bd7b19
massive refactoring to switch from camelCase to snake_case:
historically, Libervia (SàT before) was using camelCase as allowed by PEP8 when using a
pre-PEP8 code, to use the same coding style as in Twisted.
However, snake_case is more readable and it's better to follow PEP8 best practices, so it
has been decided to move on full snake_case. Because Libervia has a huge codebase, this
ended with a ugly mix of camelCase and snake_case.
To fix that, this patch does a big refactoring by renaming every function and method
(including bridge) that are not coming from Twisted or Wokkel, to use fully snake_case.
This is a massive change, and may result in some bugs.
| author | Goffi <goffi@goffi.org> |
|---|---|
| date | Sat, 08 Apr 2023 13:54:42 +0200 |
| parents | 04283582966f |
| children | 4b842c1fb686 |
line wrap: on
line diff
--- a/sat_frontends/jp/cmd_adhoc.py Fri Apr 07 15:18:39 2023 +0200 +++ b/sat_frontends/jp/cmd_adhoc.py Sat Apr 08 13:54:42 2023 +0200 @@ -75,7 +75,7 @@ if self.args.loop: flags.append(FLAG_LOOP) try: - bus_name, methods = await self.host.bridge.adHocDBusAddAuto( + bus_name, methods = await self.host.bridge.ad_hoc_dbus_add_auto( name, list(jids), self.args.groups, @@ -145,7 +145,7 @@ async def start(self): try: - xmlui_raw = await self.host.bridge.adHocRun( + xmlui_raw = await self.host.bridge.ad_hoc_run( self.args.jid, self.args.node, self.profile, @@ -159,7 +159,7 @@ await xmlui.show(workflow) if not workflow: if xmlui.type == "form": - await xmlui.submitForm() + await xmlui.submit_form() self.host.quit() @@ -181,7 +181,7 @@ async def start(self): try: - xmlui_raw = await self.host.bridge.adHocList( + xmlui_raw = await self.host.bridge.ad_hoc_list( self.args.jid, self.profile, )