Mercurial > libervia-backend

diff sat_frontends/jp/cmd_blocking.py @ 4037:524856bd7b19

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
massive refactoring to switch from camelCase to snake_case: historically, Libervia (SàT before) was using camelCase as allowed by PEP8 when using a pre-PEP8 code, to use the same coding style as in Twisted. However, snake_case is more readable and it's better to follow PEP8 best practices, so it has been decided to move on full snake_case. Because Libervia has a huge codebase, this ended with a ugly mix of camelCase and snake_case. To fix that, this patch does a big refactoring by renaming every function and method (including bridge) that are not coming from Twisted or Wokkel, to use fully snake_case. This is a massive change, and may result in some bugs.
author Goffi <goffi@goffi.org>
date Sat, 08 Apr 2023 13:54:42 +0200
parents 12317ba98d99
children 4b842c1fb686
line wrap: on
line diff
--- a/sat_frontends/jp/cmd_blocking.py	Fri Apr 07 15:18:39 2023 +0200
+++ b/sat_frontends/jp/cmd_blocking.py	Sat Apr 08 13:54:42 2023 +0200
@@ -43,7 +43,7 @@
 
     async def start(self):
         try:
-            blocked_jids = await self.host.bridge.blockingList(
+            blocked_jids = await self.host.bridge.blocking_list(
                 self.profile,
             )
         except Exception as e:
@@ -72,7 +72,7 @@
 
     async def start(self):
         try:
-            await self.host.bridge.blockingBlock(
+            await self.host.bridge.blocking_block(
                 self.args.entities,
                 self.profile
             )
@@ -108,7 +108,7 @@
     async def start(self):
         if self.args.entities == ["all"]:
             if not self.args.force:
-                await self.host.confirmOrQuit(
+                await self.host.confirm_or_quit(
                     _("All entities will be unblocked, are you sure"),
                     _("unblock cancelled")
                 )
@@ -117,7 +117,7 @@
             self.parser.error(_('--force is only allowed when "all" is used as target'))
 
         try:
-            await self.host.bridge.blockingUnblock(
+            await self.host.bridge.blocking_unblock(
                 self.args.entities,
                 self.profile
             )