Mercurial > libervia-backend

diff sat_frontends/jp/cmd_forums.py @ 4037:524856bd7b19

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
massive refactoring to switch from camelCase to snake_case: historically, Libervia (SàT before) was using camelCase as allowed by PEP8 when using a pre-PEP8 code, to use the same coding style as in Twisted. However, snake_case is more readable and it's better to follow PEP8 best practices, so it has been decided to move on full snake_case. Because Libervia has a huge codebase, this ended with a ugly mix of camelCase and snake_case. To fix that, this patch does a big refactoring by renaming every function and method (including bridge) that are not coming from Twisted or Wokkel, to use fully snake_case. This is a massive change, and may result in some bugs.
author Goffi <goffi@goffi.org>
date Sat, 08 Apr 2023 13:54:42 +0200
parents be6d91572633
children 4b842c1fb686
line wrap: on
line diff
--- a/sat_frontends/jp/cmd_forums.py	Fri Apr 07 15:18:39 2023 +0200
+++ b/sat_frontends/jp/cmd_forums.py	Sat Apr 08 13:54:42 2023 +0200
@@ -54,13 +54,13 @@
             help=_("forum key (DEFAULT: default forums)"),
         )
 
-    def getTmpSuff(self):
+    def get_tmp_suff(self):
         """return suffix used for content file"""
         return "json"
 
     async def publish(self, forums_raw):
         try:
-            await self.host.bridge.forumsSet(
+            await self.host.bridge.forums_set(
                 forums_raw,
                 self.args.service,
                 self.args.node,
@@ -76,7 +76,7 @@
 
     async def start(self):
         try:
-            forums_json = await self.host.bridge.forumsGet(
+            forums_json = await self.host.bridge.forums_get(
                 self.args.service,
                 self.args.node,
                 self.args.key,
@@ -89,7 +89,7 @@
                 self.disp(f"can't get node configuration: {e}", error=True)
                 self.host.quit(C.EXIT_BRIDGE_ERRBACK)
 
-        content_file_obj, content_file_path = self.getTmpFile()
+        content_file_obj, content_file_path = self.get_tmp_file()
         forums_json = forums_json.strip()
         if forums_json:
             # we loads and dumps to have pretty printed json
@@ -98,7 +98,7 @@
             f = codecs.getwriter("utf-8")(content_file_obj)
             json.dump(forums, f, ensure_ascii=False, indent=4)
             content_file_obj.seek(0)
-        await self.runEditor("forums_editor_args", content_file_path, content_file_obj)
+        await self.run_editor("forums_editor_args", content_file_path, content_file_obj)
 
 
 class Get(base.CommandBase):
@@ -154,7 +154,7 @@
 
     async def start(self):
         try:
-            forums_raw = await self.host.bridge.forumsGet(
+            forums_raw = await self.host.bridge.forums_get(
                 self.args.service,
                 self.args.node,
                 self.args.key,