Mercurial > libervia-backend

diff sat_frontends/jp/cmd_merge_request.py @ 4037:524856bd7b19

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
massive refactoring to switch from camelCase to snake_case: historically, Libervia (SàT before) was using camelCase as allowed by PEP8 when using a pre-PEP8 code, to use the same coding style as in Twisted. However, snake_case is more readable and it's better to follow PEP8 best practices, so it has been decided to move on full snake_case. Because Libervia has a huge codebase, this ended with a ugly mix of camelCase and snake_case. To fix that, this patch does a big refactoring by renaming every function and method (including bridge) that are not coming from Twisted or Wokkel, to use fully snake_case. This is a massive change, and may result in some bugs.
author Goffi <goffi@goffi.org>
date Sat, 08 Apr 2023 13:54:42 +0200
parents 5f65f4e9f8cb
children 4b842c1fb686
line wrap: on
line diff
--- a/sat_frontends/jp/cmd_merge_request.py	Fri Apr 07 15:18:39 2023 +0200
+++ b/sat_frontends/jp/cmd_merge_request.py	Sat Apr 08 13:54:42 2023 +0200
@@ -76,7 +76,7 @@
                 "You are going to publish your changes to service "
                 "[{service}], are you sure ?"
             ).format(service=self.args.service)
-            await self.host.confirmOrQuit(
+            await self.host.confirm_or_quit(
                 message, _("merge request publication cancelled")
             )
 
@@ -85,7 +85,7 @@
         if self.args.labels is not None:
             values["labels"] = self.args.labels
         try:
-            published_id = await self.host.bridge.mergeRequestSet(
+            published_id = await self.host.bridge.merge_request_set(
                 self.args.service,
                 self.args.node,
                 self.repository,
@@ -133,7 +133,7 @@
         extra = {}
         try:
             requests_data = data_format.deserialise(
-                await self.host.bridge.mergeRequestsGet(
+                await self.host.bridge.merge_requests_get(
                     self.args.service,
                     self.args.node,
                     self.args.max,
@@ -186,7 +186,7 @@
         )
         extra = {}
         try:
-            await self.host.bridge.mergeRequestsImport(
+            await self.host.bridge.merge_requests_import(
                 self.repository,
                 self.args.item,
                 self.args.service,