Mercurial > libervia-backend
diff sat_frontends/jp/xml_tools.py @ 4037:524856bd7b19
massive refactoring to switch from camelCase to snake_case:
historically, Libervia (SàT before) was using camelCase as allowed by PEP8 when using a
pre-PEP8 code, to use the same coding style as in Twisted.
However, snake_case is more readable and it's better to follow PEP8 best practices, so it
has been decided to move on full snake_case. Because Libervia has a huge codebase, this
ended with a ugly mix of camelCase and snake_case.
To fix that, this patch does a big refactoring by renaming every function and method
(including bridge) that are not coming from Twisted or Wokkel, to use fully snake_case.
This is a massive change, and may result in some bugs.
author | Goffi <goffi@goffi.org> |
---|---|
date | Sat, 08 Apr 2023 13:54:42 +0200 |
parents | be6d91572633 |
children | 4b842c1fb686 |
line wrap: on
line diff
--- a/sat_frontends/jp/xml_tools.py Fri Apr 07 15:18:39 2023 +0200 +++ b/sat_frontends/jp/xml_tools.py Sat Apr 08 13:54:42 2023 +0200 @@ -20,8 +20,8 @@ from sat.core.i18n import _ from sat_frontends.jp.constants import Const as C -def etreeParse(cmd, raw_xml, reraise=False): - """Import lxml and parse raw XML +def etree_parse(cmd, raw_xml, reraise=False): + """import lxml and parse raw XML @param cmd(CommandBase): current command instance @param raw_xml(file, str): an XML bytestring, string or file-like object @@ -51,7 +51,7 @@ ) return element, etree -def getPayload(cmd, element): +def get_payload(cmd, element): """Retrieve payload element and exit with and error if not found @param element(etree.Element): root element