Mercurial > libervia-backend

diff sat_frontends/primitivus/widget.py @ 4037:524856bd7b19

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
massive refactoring to switch from camelCase to snake_case: historically, Libervia (SàT before) was using camelCase as allowed by PEP8 when using a pre-PEP8 code, to use the same coding style as in Twisted. However, snake_case is more readable and it's better to follow PEP8 best practices, so it has been decided to move on full snake_case. Because Libervia has a huge codebase, this ended with a ugly mix of camelCase and snake_case. To fix that, this patch does a big refactoring by renaming every function and method (including bridge) that are not coming from Twisted or Wokkel, to use fully snake_case. This is a massive change, and may result in some bugs.
author Goffi <goffi@goffi.org>
date Sat, 08 Apr 2023 13:54:42 +0200
parents be6d91572633
children 4b842c1fb686
line wrap: on
line diff
--- a/sat_frontends/primitivus/widget.py	Fri Apr 07 15:18:39 2023 +0200
+++ b/sat_frontends/primitivus/widget.py	Sat Apr 08 13:54:42 2023 +0200
@@ -32,7 +32,7 @@
         self._title = title
         self._title_dynamic = None
         self._original_widget = w
-        urwid.WidgetWrap.__init__(self, self._getDecoration(w))
+        urwid.WidgetWrap.__init__(self, self._get_decoration(w))
 
     @property
     def title(self):
@@ -65,8 +65,8 @@
     @title.setter
     def title(self, value):
         self._title = value
-        if self.decorationVisible:
-            self.showDecoration()
+        if self.decoration_visible:
+            self.show_decoration()
 
     @property
     def title_dynamic(self):
@@ -76,29 +76,29 @@
     @title_dynamic.setter
     def title_dynamic(self, value):
         self._title_dynamic = value
-        if self.decorationVisible:
-            self.showDecoration()
+        if self.decoration_visible:
+            self.show_decoration()
 
     @property
-    def decorationVisible(self):
+    def decoration_visible(self):
         """True if the decoration is visible"""
         return isinstance(self._w, sat_widgets.LabelLine)
 
     def keypress(self, size, key):
         if key == a_key["DECORATION_HIDE"]:  # user wants to (un)hide widget decoration
-            show = not self.decorationVisible
-            self.showDecoration(show)
+            show = not self.decoration_visible
+            self.show_decoration(show)
         else:
             return super(PrimitivusWidget, self).keypress(size, key)
 
-    def _getDecoration(self, widget):
+    def _get_decoration(self, widget):
         return sat_widgets.LabelLine(widget, self.title)
 
-    def showDecoration(self, show=True):
+    def show_decoration(self, show=True):
         """Show/Hide the decoration around the window"""
         self._w = (
-            self._getDecoration(self._original_widget) if show else self._original_widget
+            self._get_decoration(self._original_widget) if show else self._original_widget
         )
 
-    def getMenu(self):
+    def get_menu(self):
         raise NotImplementedError