Mercurial > libervia-backend
diff twisted/plugins/sat_plugin.py @ 4037:524856bd7b19
massive refactoring to switch from camelCase to snake_case:
historically, Libervia (SàT before) was using camelCase as allowed by PEP8 when using a
pre-PEP8 code, to use the same coding style as in Twisted.
However, snake_case is more readable and it's better to follow PEP8 best practices, so it
has been decided to move on full snake_case. Because Libervia has a huge codebase, this
ended with a ugly mix of camelCase and snake_case.
To fix that, this patch does a big refactoring by renaming every function and method
(including bridge) that are not coming from Twisted or Wokkel, to use fully snake_case.
This is a massive change, and may result in some bugs.
| author | Goffi <goffi@goffi.org> |
|---|---|
| date | Sat, 08 Apr 2023 13:54:42 +0200 |
| parents | f9a5b810f14d |
| children | 4b842c1fb686 |
line wrap: on
line diff
--- a/twisted/plugins/sat_plugin.py Fri Apr 07 15:18:39 2023 +0200 +++ b/twisted/plugins/sat_plugin.py Sat Apr 08 13:54:42 2023 +0200 @@ -36,7 +36,7 @@ """Method to initialise global modules""" # XXX: We need to configure logs before any log method is used, so here is the best place. from sat.core import log_config - log_config.satConfigure(C.LOG_BACKEND_TWISTED, C, backend_data=options) + log_config.sat_configure(C.LOG_BACKEND_TWISTED, C, backend_data=options) class Options(usage.Options): @@ -50,7 +50,7 @@ description = _("%s XMPP client backend") % C.APP_NAME_FULL options = Options - def setDebugger(self): + def set_debugger(self): from twisted.internet import defer if defer.Deferred.debug: # if we are in debug mode, we want to use ipdb instead of pdb @@ -65,7 +65,7 @@ def makeService(self, options): from twisted.internet import asyncioreactor asyncioreactor.install() - self.setDebugger() + self.set_debugger() # XXX: Libervia must be imported after log configuration, # because it write stuff to logs initialise(options.parent)