diff sat/plugins/plugin_xep_0060.py @ 2624:56f94936df1e

code style reformatting using black
author Goffi <goffi@goffi.org>
date Wed, 27 Jun 2018 20:14:46 +0200
parents 26edcf3a30eb
children 189e38fb11ff
line wrap: on
line diff
--- a/sat/plugins/plugin_xep_0060.py	Wed Jun 27 07:51:29 2018 +0200
+++ b/sat/plugins/plugin_xep_0060.py	Wed Jun 27 20:14:46 2018 +0200
@@ -20,6 +20,7 @@
 from sat.core.i18n import _
 from sat.core.constants import Const as C
 from sat.core.log import getLogger
+
 log = getLogger(__name__)
 from sat.core import exceptions
 from sat.tools import sat_defer
@@ -33,6 +34,7 @@
 import urllib
 import datetime
 from dateutil import tz
+
 # XXX: sat_tmp.wokkel.pubsub is actually use instead of wokkel version
 #      mam and rsm come from sat_tmp.wokkel too
 from wokkel import pubsub
@@ -49,70 +51,226 @@
     C.PI_RECOMMENDATIONS: ["XEP-0313"],
     C.PI_MAIN: "XEP_0060",
     C.PI_HANDLER: "yes",
-    C.PI_DESCRIPTION: _("""Implementation of PubSub Protocol""")
+    C.PI_DESCRIPTION: _("""Implementation of PubSub Protocol"""),
 }
 
 UNSPECIFIED = "unspecified error"
 MAM_FILTER = "mam_filter_"
 
 
-Extra = namedtuple('Extra', ('rsm_request', 'extra'))
+Extra = namedtuple("Extra", ("rsm_request", "extra"))
 # rsm_request is the rsm.RSMRequest build with rsm_ prefixed keys, or None
 # extra is a potentially empty dict
 
 
 class XEP_0060(object):
-    OPT_ACCESS_MODEL = 'pubsub#access_model'
-    OPT_PERSIST_ITEMS = 'pubsub#persist_items'
-    OPT_MAX_ITEMS = 'pubsub#max_items'
-    OPT_DELIVER_PAYLOADS = 'pubsub#deliver_payloads'
-    OPT_SEND_ITEM_SUBSCRIBE = 'pubsub#send_item_subscribe'
-    OPT_NODE_TYPE = 'pubsub#node_type'
-    OPT_SUBSCRIPTION_TYPE = 'pubsub#subscription_type'
-    OPT_SUBSCRIPTION_DEPTH = 'pubsub#subscription_depth'
-    OPT_ROSTER_GROUPS_ALLOWED = 'pubsub#roster_groups_allowed'
-    OPT_PUBLISH_MODEL = 'pubsub#publish_model'
-    ACCESS_OPEN = 'open'
-    ACCESS_PRESENCE = 'presence'
-    ACCESS_ROSTER = 'roster'
-    ACCESS_PUBLISHER_ROSTER = 'publisher-roster'
-    ACCESS_AUTHORIZE = 'authorize'
-    ACCESS_WHITELIST = 'whitelist'
+    OPT_ACCESS_MODEL = "pubsub#access_model"
+    OPT_PERSIST_ITEMS = "pubsub#persist_items"
+    OPT_MAX_ITEMS = "pubsub#max_items"
+    OPT_DELIVER_PAYLOADS = "pubsub#deliver_payloads"
+    OPT_SEND_ITEM_SUBSCRIBE = "pubsub#send_item_subscribe"
+    OPT_NODE_TYPE = "pubsub#node_type"
+    OPT_SUBSCRIPTION_TYPE = "pubsub#subscription_type"
+    OPT_SUBSCRIPTION_DEPTH = "pubsub#subscription_depth"
+    OPT_ROSTER_GROUPS_ALLOWED = "pubsub#roster_groups_allowed"
+    OPT_PUBLISH_MODEL = "pubsub#publish_model"
+    ACCESS_OPEN = "open"
+    ACCESS_PRESENCE = "presence"
+    ACCESS_ROSTER = "roster"
+    ACCESS_PUBLISHER_ROSTER = "publisher-roster"
+    ACCESS_AUTHORIZE = "authorize"
+    ACCESS_WHITELIST = "whitelist"
 
     def __init__(self, host):
         log.info(_(u"PubSub plugin initialization"))
         self.host = host
-        self._mam = host.plugins.get('XEP-0313')
-        self._node_cb = {} # dictionnary of callbacks for node (key: node, value: list of callbacks)
+        self._mam = host.plugins.get("XEP-0313")
+        self._node_cb = {}  # dictionnary of callbacks for node (key: node, value: list of callbacks)
         self.rt_sessions = sat_defer.RTDeferredSessions()
-        host.bridge.addMethod("psNodeCreate", ".plugin", in_sign='ssa{ss}s', out_sign='s', method=self._createNode, async=True)
-        host.bridge.addMethod("psNodeConfigurationGet", ".plugin", in_sign='sss', out_sign='a{ss}', method=self._getNodeConfiguration, async=True)
-        host.bridge.addMethod("psNodeConfigurationSet", ".plugin", in_sign='ssa{ss}s', out_sign='', method=self._setNodeConfiguration, async=True)
-        host.bridge.addMethod("psNodeAffiliationsGet", ".plugin", in_sign='sss', out_sign='a{ss}', method=self._getNodeAffiliations, async=True)
-        host.bridge.addMethod("psNodeAffiliationsSet", ".plugin", in_sign='ssa{ss}s', out_sign='', method=self._setNodeAffiliations, async=True)
-        host.bridge.addMethod("psNodeSubscriptionsGet", ".plugin", in_sign='sss', out_sign='a{ss}', method=self._getNodeSubscriptions, async=True)
-        host.bridge.addMethod("psNodeSubscriptionsSet", ".plugin", in_sign='ssa{ss}s', out_sign='', method=self._setNodeSubscriptions, async=True)
-        host.bridge.addMethod("psNodeDelete", ".plugin", in_sign='sss', out_sign='', method=self._deleteNode, async=True)
-        host.bridge.addMethod("psNodeWatchAdd", ".plugin", in_sign='sss', out_sign='', method=self._addWatch, async=False)
-        host.bridge.addMethod("psNodeWatchRemove", ".plugin", in_sign='sss', out_sign='', method=self._removeWatch, async=False)
-        host.bridge.addMethod("psAffiliationsGet", ".plugin", in_sign='sss', out_sign='a{ss}', method=self._getAffiliations, async=True)
-        host.bridge.addMethod("psItemsGet", ".plugin", in_sign='ssiassa{ss}s', out_sign='(asa{ss})', method=self._getItems, async=True)
-        host.bridge.addMethod("psItemSend", ".plugin", in_sign='ssssa{ss}s', out_sign='s', method=self._sendItem, async=True)
-        host.bridge.addMethod("psRetractItem", ".plugin", in_sign='sssbs', out_sign='', method=self._retractItem, async=True)
-        host.bridge.addMethod("psRetractItems", ".plugin", in_sign='ssasbs', out_sign='', method=self._retractItems, async=True)
-        host.bridge.addMethod("psSubscribe", ".plugin", in_sign='ssa{ss}s', out_sign='s', method=self._subscribe, async=True)
-        host.bridge.addMethod("psUnsubscribe", ".plugin", in_sign='sss', out_sign='', method=self._unsubscribe, async=True)
-        host.bridge.addMethod("psSubscriptionsGet", ".plugin", in_sign='sss', out_sign='aa{ss}', method=self._subscriptions, async=True)
-        host.bridge.addMethod("psSubscribeToMany", ".plugin", in_sign='a(ss)sa{ss}s', out_sign='s', method=self._subscribeToMany)
-        host.bridge.addMethod("psGetSubscribeRTResult", ".plugin", in_sign='ss', out_sign='(ua(sss))', method=self._manySubscribeRTResult, async=True)
-        host.bridge.addMethod("psGetFromMany", ".plugin", in_sign='a(ss)ia{ss}s', out_sign='s', method=self._getFromMany)
-        host.bridge.addMethod("psGetFromManyRTResult", ".plugin", in_sign='ss', out_sign='(ua(sssasa{ss}))', method=self._getFromManyRTResult, async=True)
+        host.bridge.addMethod(
+            "psNodeCreate",
+            ".plugin",
+            in_sign="ssa{ss}s",
+            out_sign="s",
+            method=self._createNode,
+            async=True,
+        )
+        host.bridge.addMethod(
+            "psNodeConfigurationGet",
+            ".plugin",
+            in_sign="sss",
+            out_sign="a{ss}",
+            method=self._getNodeConfiguration,
+            async=True,
+        )
+        host.bridge.addMethod(
+            "psNodeConfigurationSet",
+            ".plugin",
+            in_sign="ssa{ss}s",
+            out_sign="",
+            method=self._setNodeConfiguration,
+            async=True,
+        )
+        host.bridge.addMethod(
+            "psNodeAffiliationsGet",
+            ".plugin",
+            in_sign="sss",
+            out_sign="a{ss}",
+            method=self._getNodeAffiliations,
+            async=True,
+        )
+        host.bridge.addMethod(
+            "psNodeAffiliationsSet",
+            ".plugin",
+            in_sign="ssa{ss}s",
+            out_sign="",
+            method=self._setNodeAffiliations,
+            async=True,
+        )
+        host.bridge.addMethod(
+            "psNodeSubscriptionsGet",
+            ".plugin",
+            in_sign="sss",
+            out_sign="a{ss}",
+            method=self._getNodeSubscriptions,
+            async=True,
+        )
+        host.bridge.addMethod(
+            "psNodeSubscriptionsSet",
+            ".plugin",
+            in_sign="ssa{ss}s",
+            out_sign="",
+            method=self._setNodeSubscriptions,
+            async=True,
+        )
+        host.bridge.addMethod(
+            "psNodeDelete",
+            ".plugin",
+            in_sign="sss",
+            out_sign="",
+            method=self._deleteNode,
+            async=True,
+        )
+        host.bridge.addMethod(
+            "psNodeWatchAdd",
+            ".plugin",
+            in_sign="sss",
+            out_sign="",
+            method=self._addWatch,
+            async=False,
+        )
+        host.bridge.addMethod(
+            "psNodeWatchRemove",
+            ".plugin",
+            in_sign="sss",
+            out_sign="",
+            method=self._removeWatch,
+            async=False,
+        )
+        host.bridge.addMethod(
+            "psAffiliationsGet",
+            ".plugin",
+            in_sign="sss",
+            out_sign="a{ss}",
+            method=self._getAffiliations,
+            async=True,
+        )
+        host.bridge.addMethod(
+            "psItemsGet",
+            ".plugin",
+            in_sign="ssiassa{ss}s",
+            out_sign="(asa{ss})",
+            method=self._getItems,
+            async=True,
+        )
+        host.bridge.addMethod(
+            "psItemSend",
+            ".plugin",
+            in_sign="ssssa{ss}s",
+            out_sign="s",
+            method=self._sendItem,
+            async=True,
+        )
+        host.bridge.addMethod(
+            "psRetractItem",
+            ".plugin",
+            in_sign="sssbs",
+            out_sign="",
+            method=self._retractItem,
+            async=True,
+        )
+        host.bridge.addMethod(
+            "psRetractItems",
+            ".plugin",
+            in_sign="ssasbs",
+            out_sign="",
+            method=self._retractItems,
+            async=True,
+        )
+        host.bridge.addMethod(
+            "psSubscribe",
+            ".plugin",
+            in_sign="ssa{ss}s",
+            out_sign="s",
+            method=self._subscribe,
+            async=True,
+        )
+        host.bridge.addMethod(
+            "psUnsubscribe",
+            ".plugin",
+            in_sign="sss",
+            out_sign="",
+            method=self._unsubscribe,
+            async=True,
+        )
+        host.bridge.addMethod(
+            "psSubscriptionsGet",
+            ".plugin",
+            in_sign="sss",
+            out_sign="aa{ss}",
+            method=self._subscriptions,
+            async=True,
+        )
+        host.bridge.addMethod(
+            "psSubscribeToMany",
+            ".plugin",
+            in_sign="a(ss)sa{ss}s",
+            out_sign="s",
+            method=self._subscribeToMany,
+        )
+        host.bridge.addMethod(
+            "psGetSubscribeRTResult",
+            ".plugin",
+            in_sign="ss",
+            out_sign="(ua(sss))",
+            method=self._manySubscribeRTResult,
+            async=True,
+        )
+        host.bridge.addMethod(
+            "psGetFromMany",
+            ".plugin",
+            in_sign="a(ss)ia{ss}s",
+            out_sign="s",
+            method=self._getFromMany,
+        )
+        host.bridge.addMethod(
+            "psGetFromManyRTResult",
+            ".plugin",
+            in_sign="ss",
+            out_sign="(ua(sssasa{ss}))",
+            method=self._getFromManyRTResult,
+            async=True,
+        )
 
-        # high level observer method
-        host.bridge.addSignal("psEvent", ".plugin", signature='ssssa{ss}s')  # args: category, service(jid), node, type (C.PS_ITEMS, C.PS_DELETE), data, profile
+        #  high level observer method
+        host.bridge.addSignal(
+            "psEvent", ".plugin", signature="ssssa{ss}s"
+        )  # args: category, service(jid), node, type (C.PS_ITEMS, C.PS_DELETE), data, profile
 
         # low level observer method, used if service/node is in watching list (see psNodeWatch* methods)
-        host.bridge.addSignal("psEventRaw", ".plugin", signature='sssass')  # args: service(jid), node, type (C.PS_ITEMS, C.PS_DELETE), list of item_xml, profile
+        host.bridge.addSignal(
+            "psEventRaw", ".plugin", signature="sssass"
+        )  # args: service(jid), node, type (C.PS_ITEMS, C.PS_DELETE), list of item_xml, profile
 
     def getHandler(self, client):
         client.pubsub_client = SatPubSubClient(self.host, self)
@@ -122,10 +280,18 @@
     def profileConnected(self, client):
         client.pubsub_watching = set()
         try:
-            client.pubsub_service = jid.JID(self.host.memory.getConfig('', 'pubsub_service'))
+            client.pubsub_service = jid.JID(
+                self.host.memory.getConfig("", "pubsub_service")
+            )
         except RuntimeError:
-            log.info(_(u"Can't retrieve pubsub_service from conf, we'll use first one that we find"))
-            client.pubsub_service = yield self.host.findServiceEntity(client, "pubsub", "service")
+            log.info(
+                _(
+                    u"Can't retrieve pubsub_service from conf, we'll use first one that we find"
+                )
+            )
+            client.pubsub_service = yield self.host.findServiceEntity(
+                client, "pubsub", "service"
+            )
 
     def getFeatures(self, profile):
         try:
@@ -133,7 +299,11 @@
         except exceptions.ProfileNotSetError:
             return {}
         try:
-            return {'service': client.pubsub_service.full() if client.pubsub_service is not None else  ''}
+            return {
+                "service": client.pubsub_service.full()
+                if client.pubsub_service is not None
+                else ""
+            }
         except AttributeError:
             if self.host.isConnected(profile):
                 log.debug("Profile is not connected, service is not checked yet")
@@ -154,10 +324,10 @@
         else:
             # rsm
             rsm_args = {}
-            for arg in ('max', 'after', 'before', 'index'):
+            for arg in ("max", "after", "before", "index"):
                 try:
-                    argname = "max_" if arg == 'max' else arg
-                    rsm_args[argname] = extra.pop('rsm_{}'.format(arg))
+                    argname = "max_" if arg == "max" else arg
+                    rsm_args[argname] = extra.pop("rsm_{}".format(arg))
                 except KeyError:
                     continue
 
@@ -168,16 +338,18 @@
 
             # mam
             mam_args = {}
-            for arg in ('start', 'end'):
+            for arg in ("start", "end"):
                 try:
-                    mam_args[arg] = datetime.datetime.fromtimestamp(int(extra.pop('{}{}'.format(MAM_FILTER, arg))), tz.tzutc())
+                    mam_args[arg] = datetime.datetime.fromtimestamp(
+                        int(extra.pop("{}{}".format(MAM_FILTER, arg))), tz.tzutc()
+                    )
                 except (TypeError, ValueError):
                     log.warning(u"Bad value for {} filter".format(arg))
                 except KeyError:
                     continue
 
             try:
-                mam_args['with_jid'] = jid.JID(extra.pop('{}jid'.format(MAM_FILTER)))
+                mam_args["with_jid"] = jid.JID(extra.pop("{}jid".format(MAM_FILTER)))
             except (jid.InvalidFormat):
                 log.warning(u"Bad value for jid filter")
             except KeyError:
@@ -185,13 +357,13 @@
 
             for name, value in extra.iteritems():
                 if name.startswith(MAM_FILTER):
-                    var = name[len(MAM_FILTER):]
-                    extra_fields = mam_args.setdefault('extra_fields', [])
+                    var = name[len(MAM_FILTER) :]
+                    extra_fields = mam_args.setdefault("extra_fields", [])
                     extra_fields.append(data_form.Field(var=var, value=value))
 
             if mam_args:
-                assert 'mam' not in extra
-                extra['mam'] = mam.MAMRequest(mam.buildForm(**mam_args))
+                assert "mam" not in extra
+                extra["mam"] = mam.MAMRequest(mam.buildForm(**mam_args))
         return Extra(rsm_request, extra)
 
     def addManagedNode(self, node, **kwargs):
@@ -210,7 +382,7 @@
         for event, cb in kwargs.iteritems():
             event_name = event[:-3]
             assert event_name in C.PS_EVENTS
-            callbacks.setdefault(event_name,[]).append(cb)
+            callbacks.setdefault(event_name, []).append(cb)
 
     def removeManagedNode(self, node, *args):
         """Add a handler for a node
@@ -231,14 +403,21 @@
                     except ValueError:
                         pass
                     else:
-                        log.debug(u"removed callback {cb} for event {event} on node {node}".format(
-                            cb=callback, event=event, node=node))
+                        log.debug(
+                            u"removed callback {cb} for event {event} on node {node}".format(
+                                cb=callback, event=event, node=node
+                            )
+                        )
                         if not cb_list:
                             del registred_cb[event]
                         if not registred_cb:
                             del self._node_cb[node]
                         return
-        log.error(u"Trying to remove inexistant callback {cb} for node {node}".format(cb=callback, node=node))
+        log.error(
+            u"Trying to remove inexistant callback {cb} for node {node}".format(
+                cb=callback, node=node
+            )
+        )
 
     # def listNodes(self, service, nodeIdentifier='', profile=C.PROF_KEY_NONE):
     #     """Retrieve the name of the nodes that are accessible on the target service.
@@ -270,11 +449,21 @@
     #     d.addCallback(lambda subs: [sub.getAttribute('node') for sub in subs if sub.getAttribute('subscription') == filter_])
     #     return d
 
-    def _sendItem(self, service, nodeIdentifier, payload, item_id=None, extra=None, profile_key=C.PROF_KEY_NONE):
+    def _sendItem(
+        self,
+        service,
+        nodeIdentifier,
+        payload,
+        item_id=None,
+        extra=None,
+        profile_key=C.PROF_KEY_NONE,
+    ):
         client = self.host.getClient(profile_key)
         service = None if not service else jid.JID(service)
-        d = self.sendItem(client, service, nodeIdentifier, payload, item_id or None, extra)
-        d.addCallback(lambda ret: ret or u'')
+        d = self.sendItem(
+            client, service, nodeIdentifier, payload, item_id or None, extra
+        )
+        d.addCallback(lambda ret: ret or u"")
         return d
 
     def _getPublishedItemId(self, iq_elt, original_id):
@@ -283,12 +472,14 @@
         if not found original_id is returned, or empty string if it is None or empty string
         """
         try:
-            item_id = iq_elt.pubsub.publish.item['id']
+            item_id = iq_elt.pubsub.publish.item["id"]
         except (AttributeError, KeyError):
             item_id = None
         return item_id or original_id
 
-    def sendItem(self, client, service, nodeIdentifier, payload, item_id=None, extra=None):
+    def sendItem(
+        self, client, service, nodeIdentifier, payload, item_id=None, extra=None
+    ):
         """high level method to send one item
 
         @param service(jid.JID, None): service to send the item to
@@ -305,21 +496,40 @@
         return d
 
     def publish(self, client, service, nodeIdentifier, items=None):
-        return client.pubsub_client.publish(service, nodeIdentifier, items, client.pubsub_client.parent.jid)
+        return client.pubsub_client.publish(
+            service, nodeIdentifier, items, client.pubsub_client.parent.jid
+        )
 
     def _unwrapMAMMessage(self, message_elt):
         try:
-            item_elt = (message_elt.elements(mam.NS_MAM, 'result').next()
-                                   .elements(C.NS_FORWARD, 'forwarded').next()
-                                   .elements(C.NS_CLIENT, 'message').next()
-                                   .elements('http://jabber.org/protocol/pubsub#event', 'event').next()
-                                   .elements('http://jabber.org/protocol/pubsub#event', 'items').next()
-                                   .elements('http://jabber.org/protocol/pubsub#event', 'item').next())
+            item_elt = (
+                message_elt.elements(mam.NS_MAM, "result")
+                .next()
+                .elements(C.NS_FORWARD, "forwarded")
+                .next()
+                .elements(C.NS_CLIENT, "message")
+                .next()
+                .elements("http://jabber.org/protocol/pubsub#event", "event")
+                .next()
+                .elements("http://jabber.org/protocol/pubsub#event", "items")
+                .next()
+                .elements("http://jabber.org/protocol/pubsub#event", "item")
+                .next()
+            )
         except StopIteration:
             raise exceptions.DataError(u"Can't find Item in MAM message element")
         return item_elt
 
-    def _getItems(self, service='', node='', max_items=10, item_ids=None, sub_id=None, extra_dict=None, profile_key=C.PROF_KEY_NONE):
+    def _getItems(
+        self,
+        service="",
+        node="",
+        max_items=10,
+        item_ids=None,
+        sub_id=None,
+        extra_dict=None,
+        profile_key=C.PROF_KEY_NONE,
+    ):
         """Get items from pubsub node
 
         @param max_items(int): maximum number of item to get, C.NO_LIMIT for no limit
@@ -328,11 +538,30 @@
         service = jid.JID(service) if service else None
         max_items = None if max_items == C.NO_LIMIT else max_items
         extra = self.parseExtra(extra_dict)
-        d = self.getItems(client, service, node or None, max_items or None, item_ids, sub_id or None, extra.rsm_request, extra.extra)
+        d = self.getItems(
+            client,
+            service,
+            node or None,
+            max_items or None,
+            item_ids,
+            sub_id or None,
+            extra.rsm_request,
+            extra.extra,
+        )
         d.addCallback(self.serItemsData)
         return d
 
-    def getItems(self, client, service, node, max_items=None, item_ids=None, sub_id=None, rsm_request=None, extra=None):
+    def getItems(
+        self,
+        client,
+        service,
+        node,
+        max_items=None,
+        item_ids=None,
+        sub_id=None,
+        rsm_request=None,
+        extra=None,
+    ):
         """Retrieve pubsub items from a node.
 
         @param service (JID, None): pubsub service.
@@ -354,9 +583,11 @@
         if extra is None:
             extra = {}
         try:
-            mam_query = extra['mam']
+            mam_query = extra["mam"]
         except KeyError:
-            d = client.pubsub_client.items(service, node, max_items, item_ids, sub_id, None, rsm_request)
+            d = client.pubsub_client.items(
+                service, node, max_items, item_ids, sub_id, None, rsm_request
+            )
         else:
             # if mam is requested, we have to do a totally different query
             if self._mam is None:
@@ -368,25 +599,35 @@
             if mam_query.node is None:
                 mam_query.node = node
             elif mam_query.node != node:
-                raise exceptions.DataError(u"MAM query node is incoherent with getItems's node")
+                raise exceptions.DataError(
+                    u"MAM query node is incoherent with getItems's node"
+                )
             if mam_query.rsm is None:
                 mam_query.rsm = rsm_request
             else:
                 if mam_query.rsm != rsm_request:
-                    raise exceptions.DataError(u"Conflict between RSM request and MAM's RSM request")
+                    raise exceptions.DataError(
+                        u"Conflict between RSM request and MAM's RSM request"
+                    )
             d = self._mam.getArchives(client, mam_query, service, self._unwrapMAMMessage)
 
         try:
-            subscribe = C.bool(extra['subscribe'])
+            subscribe = C.bool(extra["subscribe"])
         except KeyError:
             subscribe = False
 
         def subscribeEb(failure, service, node):
             failure.trap(error.StanzaError)
-            log.warning(u"Could not subscribe to node {} on service {}: {}".format(node, unicode(service), unicode(failure.value)))
+            log.warning(
+                u"Could not subscribe to node {} on service {}: {}".format(
+                    node, unicode(service), unicode(failure.value)
+                )
+            )
 
         def doSubscribe(items):
-            self.subscribe(service, node, profile_key=client.profile).addErrback(subscribeEb, service, node)
+            self.subscribe(service, node, profile_key=client.profile).addErrback(
+                subscribeEb, service, node
+            )
             return items
 
         if subscribe:
@@ -395,12 +636,18 @@
         def addMetadata(result):
             items, rsm_response = result
             service_jid = service if service else client.jid.userhostJID()
-            metadata = {'service': service_jid,
-                        'node': node,
-                        'uri': self.getNodeURI(service_jid, node),
-                       }
+            metadata = {
+                "service": service_jid,
+                "node": node,
+                "uri": self.getNodeURI(service_jid, node),
+            }
             if rsm_request is not None and rsm_response is not None:
-                metadata.update({'rsm_{}'.format(key): value for key, value in rsm_response.toDict().iteritems()})
+                metadata.update(
+                    {
+                        "rsm_{}".format(key): value
+                        for key, value in rsm_response.toDict().iteritems()
+                    }
+                )
             return (items, metadata)
 
         d.addCallback(addMetadata)
@@ -431,17 +678,38 @@
     #         d_dict[publisher] = self.getItems(service, node, max_items, None, sub_id, rsm, client.profile)
     #     defer.returnValue(d_dict)
 
-    def getOptions(self, service, nodeIdentifier, subscriber, subscriptionIdentifier=None, profile_key=C.PROF_KEY_NONE):
+    def getOptions(
+        self,
+        service,
+        nodeIdentifier,
+        subscriber,
+        subscriptionIdentifier=None,
+        profile_key=C.PROF_KEY_NONE,
+    ):
         client = self.host.getClient(profile_key)
-        return client.pubsub_client.getOptions(service, nodeIdentifier, subscriber, subscriptionIdentifier)
+        return client.pubsub_client.getOptions(
+            service, nodeIdentifier, subscriber, subscriptionIdentifier
+        )
 
-    def setOptions(self, service, nodeIdentifier, subscriber, options, subscriptionIdentifier=None, profile_key=C.PROF_KEY_NONE):
+    def setOptions(
+        self,
+        service,
+        nodeIdentifier,
+        subscriber,
+        options,
+        subscriptionIdentifier=None,
+        profile_key=C.PROF_KEY_NONE,
+    ):
         client = self.host.getClient(profile_key)
-        return client.pubsub_client.setOptions(service, nodeIdentifier, subscriber, options, subscriptionIdentifier)
+        return client.pubsub_client.setOptions(
+            service, nodeIdentifier, subscriber, options, subscriptionIdentifier
+        )
 
     def _createNode(self, service_s, nodeIdentifier, options, profile_key):
         client = self.host.getClient(profile_key)
-        return self.createNode(client, jid.JID(service_s) if service_s else None, nodeIdentifier, options)
+        return self.createNode(
+            client, jid.JID(service_s) if service_s else None, nodeIdentifier, options
+        )
 
     def createNode(self, client, service, nodeIdentifier=None, options=None):
         """Create a new node
@@ -461,28 +729,31 @@
         try:
             yield self.createNode(client, service, nodeIdentifier, options)
         except error.StanzaError as e:
-            if e.condition == 'conflict':
+            if e.condition == "conflict":
                 pass
             else:
                 raise e
 
     def _getNodeConfiguration(self, service_s, nodeIdentifier, profile_key):
         client = self.host.getClient(profile_key)
-        d = self.getConfiguration(client, jid.JID(service_s) if service_s else None, nodeIdentifier)
+        d = self.getConfiguration(
+            client, jid.JID(service_s) if service_s else None, nodeIdentifier
+        )
+
         def serialize(form):
             # FIXME: better more generic dataform serialisation should be available in SàT
             return {f.var: unicode(f.value) for f in form.fields.values()}
+
         d.addCallback(serialize)
         return d
 
     def getConfiguration(self, client, service, nodeIdentifier):
-        request = pubsub.PubSubRequest('configureGet')
+        request = pubsub.PubSubRequest("configureGet")
         request.recipient = service
         request.nodeIdentifier = nodeIdentifier
 
         def cb(iq):
-            form = data_form.findForm(iq.pubsub.configure,
-                                      pubsub.NS_PUBSUB_NODE_CONFIG)
+            form = data_form.findForm(iq.pubsub.configure, pubsub.NS_PUBSUB_NODE_CONFIG)
             form.typeCheck()
             return form
 
@@ -492,16 +763,19 @@
 
     def _setNodeConfiguration(self, service_s, nodeIdentifier, options, profile_key):
         client = self.host.getClient(profile_key)
-        d = self.setConfiguration(client, jid.JID(service_s) if service_s else None, nodeIdentifier, options)
+        d = self.setConfiguration(
+            client, jid.JID(service_s) if service_s else None, nodeIdentifier, options
+        )
         return d
 
     def setConfiguration(self, client, service, nodeIdentifier, options):
-        request = pubsub.PubSubRequest('configureSet')
+        request = pubsub.PubSubRequest("configureSet")
         request.recipient = service
         request.nodeIdentifier = nodeIdentifier
 
-        form = data_form.Form(formType='submit',
-                              formNamespace=pubsub.NS_PUBSUB_NODE_CONFIG)
+        form = data_form.Form(
+            formType="submit", formNamespace=pubsub.NS_PUBSUB_NODE_CONFIG
+        )
         form.makeFields(options)
         request.options = form
 
@@ -510,7 +784,9 @@
 
     def _getAffiliations(self, service_s, nodeIdentifier, profile_key):
         client = self.host.getClient(profile_key)
-        d = self.getAffiliations(client, jid.JID(service_s) if service_s else None, nodeIdentifier or None)
+        d = self.getAffiliations(
+            client, jid.JID(service_s) if service_s else None, nodeIdentifier or None
+        )
         return d
 
     def getAffiliations(self, client, service, nodeIdentifier=None):
@@ -519,19 +795,32 @@
         @param nodeIdentifier(unicode, None): node to get affiliation from
             None to get all nodes affiliations for this service
         """
-        request = pubsub.PubSubRequest('affiliations')
+        request = pubsub.PubSubRequest("affiliations")
         request.recipient = service
         request.nodeIdentifier = nodeIdentifier
 
         def cb(iq_elt):
             try:
-                affiliations_elt = next(iq_elt.pubsub.elements((pubsub.NS_PUBSUB, 'affiliations')))
+                affiliations_elt = next(
+                    iq_elt.pubsub.elements((pubsub.NS_PUBSUB, "affiliations"))
+                )
             except StopIteration:
-                raise ValueError(_(u"Invalid result: missing <affiliations> element: {}").format(iq_elt.toXml))
+                raise ValueError(
+                    _(u"Invalid result: missing <affiliations> element: {}").format(
+                        iq_elt.toXml
+                    )
+                )
             try:
-                return {e['node']: e['affiliation'] for e in affiliations_elt.elements((pubsub.NS_PUBSUB, 'affiliation'))}
+                return {
+                    e["node"]: e["affiliation"]
+                    for e in affiliations_elt.elements((pubsub.NS_PUBSUB, "affiliation"))
+                }
             except KeyError:
-                raise ValueError(_(u"Invalid result: bad <affiliation> element: {}").format(iq_elt.toXml))
+                raise ValueError(
+                    _(u"Invalid result: bad <affiliation> element: {}").format(
+                        iq_elt.toXml
+                    )
+                )
 
         d = request.send(client.xmlstream)
         d.addCallback(cb)
@@ -539,34 +828,62 @@
 
     def _getNodeAffiliations(self, service_s, nodeIdentifier, profile_key):
         client = self.host.getClient(profile_key)
-        d = self.getNodeAffiliations(client, jid.JID(service_s) if service_s else None, nodeIdentifier)
-        d.addCallback(lambda affiliations: {j.full(): a for j, a in affiliations.iteritems()})
+        d = self.getNodeAffiliations(
+            client, jid.JID(service_s) if service_s else None, nodeIdentifier
+        )
+        d.addCallback(
+            lambda affiliations: {j.full(): a for j, a in affiliations.iteritems()}
+        )
         return d
 
     def getNodeAffiliations(self, client, service, nodeIdentifier):
         """Retrieve affiliations of a node owned by profile"""
-        request = pubsub.PubSubRequest('affiliationsGet')
+        request = pubsub.PubSubRequest("affiliationsGet")
         request.recipient = service
         request.nodeIdentifier = nodeIdentifier
 
         def cb(iq_elt):
             try:
-                affiliations_elt = next(iq_elt.pubsub.elements((pubsub.NS_PUBSUB_OWNER, 'affiliations')))
+                affiliations_elt = next(
+                    iq_elt.pubsub.elements((pubsub.NS_PUBSUB_OWNER, "affiliations"))
+                )
             except StopIteration:
-                raise ValueError(_(u"Invalid result: missing <affiliations> element: {}").format(iq_elt.toXml))
+                raise ValueError(
+                    _(u"Invalid result: missing <affiliations> element: {}").format(
+                        iq_elt.toXml
+                    )
+                )
             try:
-                return {jid.JID(e['jid']): e['affiliation'] for e in affiliations_elt.elements((pubsub.NS_PUBSUB_OWNER, 'affiliation'))}
+                return {
+                    jid.JID(e["jid"]): e["affiliation"]
+                    for e in affiliations_elt.elements(
+                        (pubsub.NS_PUBSUB_OWNER, "affiliation")
+                    )
+                }
             except KeyError:
-                raise ValueError(_(u"Invalid result: bad <affiliation> element: {}").format(iq_elt.toXml))
+                raise ValueError(
+                    _(u"Invalid result: bad <affiliation> element: {}").format(
+                        iq_elt.toXml
+                    )
+                )
 
         d = request.send(client.xmlstream)
         d.addCallback(cb)
         return d
 
-    def _setNodeAffiliations(self, service_s, nodeIdentifier, affiliations, profile_key=C.PROF_KEY_NONE):
+    def _setNodeAffiliations(
+        self, service_s, nodeIdentifier, affiliations, profile_key=C.PROF_KEY_NONE
+    ):
         client = self.host.getClient(profile_key)
-        affiliations = {jid.JID(jid_): affiliation for jid_, affiliation in affiliations.iteritems()}
-        d = self.setNodeAffiliations(client, jid.JID(service_s) if service_s else None, nodeIdentifier, affiliations)
+        affiliations = {
+            jid.JID(jid_): affiliation for jid_, affiliation in affiliations.iteritems()
+        }
+        d = self.setNodeAffiliations(
+            client,
+            jid.JID(service_s) if service_s else None,
+            nodeIdentifier,
+            affiliations,
+        )
         return d
 
     def setNodeAffiliations(self, client, service, nodeIdentifier, affiliations):
@@ -575,7 +892,7 @@
         @param affiliations(dict[jid.JID, unicode]): affiliations to set
             check https://xmpp.org/extensions/xep-0060.html#affiliations for a list of possible affiliations
         """
-        request = pubsub.PubSubRequest('affiliationsSet')
+        request = pubsub.PubSubRequest("affiliationsSet")
         request.recipient = service
         request.nodeIdentifier = nodeIdentifier
         request.affiliations = affiliations
@@ -584,7 +901,9 @@
 
     def _deleteNode(self, service_s, nodeIdentifier, profile_key):
         client = self.host.getClient(profile_key)
-        return self.deleteNode(client, jid.JID(service_s) if service_s else None, nodeIdentifier)
+        return self.deleteNode(
+            client, jid.JID(service_s) if service_s else None, nodeIdentifier
+        )
 
     def deleteNode(self, client, service, nodeIdentifier):
         return client.pubsub_client.deleteNode(service, nodeIdentifier)
@@ -607,48 +926,86 @@
         service = jid.JID(service_s) if service_s else client.jid.userhostJID()
         client.pubsub_watching.remove((service, node))
 
-    def _retractItem(self, service_s, nodeIdentifier, itemIdentifier, notify, profile_key):
-        return self._retractItems(service_s, nodeIdentifier, (itemIdentifier,), notify, profile_key)
+    def _retractItem(
+        self, service_s, nodeIdentifier, itemIdentifier, notify, profile_key
+    ):
+        return self._retractItems(
+            service_s, nodeIdentifier, (itemIdentifier,), notify, profile_key
+        )
 
-    def _retractItems(self, service_s, nodeIdentifier, itemIdentifiers, notify, profile_key):
-        return self.retractItems(jid.JID(service_s) if service_s else None, nodeIdentifier, itemIdentifiers, notify, profile_key)
+    def _retractItems(
+        self, service_s, nodeIdentifier, itemIdentifiers, notify, profile_key
+    ):
+        return self.retractItems(
+            jid.JID(service_s) if service_s else None,
+            nodeIdentifier,
+            itemIdentifiers,
+            notify,
+            profile_key,
+        )
 
-    def retractItems(self, service, nodeIdentifier, itemIdentifiers, notify=True, profile_key=C.PROF_KEY_NONE):
+    def retractItems(
+        self,
+        service,
+        nodeIdentifier,
+        itemIdentifiers,
+        notify=True,
+        profile_key=C.PROF_KEY_NONE,
+    ):
         client = self.host.getClient(profile_key)
-        return client.pubsub_client.retractItems(service, nodeIdentifier, itemIdentifiers, notify=True)
+        return client.pubsub_client.retractItems(
+            service, nodeIdentifier, itemIdentifiers, notify=True
+        )
 
     def _subscribe(self, service, nodeIdentifier, options, profile_key=C.PROF_KEY_NONE):
         client = self.host.getClient(profile_key)
         service = None if not service else jid.JID(service)
         d = self.subscribe(client, service, nodeIdentifier, options=options or None)
-        d.addCallback(lambda subscription: subscription.subscriptionIdentifier or u'')
+        d.addCallback(lambda subscription: subscription.subscriptionIdentifier or u"")
         return d
 
     def subscribe(self, client, service, nodeIdentifier, sub_jid=None, options=None):
         # TODO: reimplement a subscribtion cache, checking that we have not subscription before trying to subscribe
-        return client.pubsub_client.subscribe(service, nodeIdentifier, sub_jid or client.jid.userhostJID(), options=options)
+        return client.pubsub_client.subscribe(
+            service, nodeIdentifier, sub_jid or client.jid.userhostJID(), options=options
+        )
 
     def _unsubscribe(self, service, nodeIdentifier, profile_key=C.PROF_KEY_NONE):
         client = self.host.getClient(profile_key)
         service = None if not service else jid.JID(service)
         return self.unsubscribe(client, service, nodeIdentifier)
 
-    def unsubscribe(self, client, service, nodeIdentifier, sub_jid=None, subscriptionIdentifier=None, sender=None):
-        return client.pubsub_client.unsubscribe(service, nodeIdentifier, sub_jid or client.jid.userhostJID(), subscriptionIdentifier, sender)
+    def unsubscribe(
+        self,
+        client,
+        service,
+        nodeIdentifier,
+        sub_jid=None,
+        subscriptionIdentifier=None,
+        sender=None,
+    ):
+        return client.pubsub_client.unsubscribe(
+            service,
+            nodeIdentifier,
+            sub_jid or client.jid.userhostJID(),
+            subscriptionIdentifier,
+            sender,
+        )
 
-    def _subscriptions(self, service, nodeIdentifier='', profile_key=C.PROF_KEY_NONE):
+    def _subscriptions(self, service, nodeIdentifier="", profile_key=C.PROF_KEY_NONE):
         client = self.host.getClient(profile_key)
         service = None if not service else jid.JID(service)
 
         def gotSubscriptions(subscriptions):
             # we replace pubsub.Subscription instance by dict that we can serialize
             for idx, sub in enumerate(subscriptions):
-                sub_dict = {'node': sub.nodeIdentifier,
-                            'subscriber': sub.subscriber.full(),
-                            'state': sub.state
-                           }
+                sub_dict = {
+                    "node": sub.nodeIdentifier,
+                    "subscriber": sub.subscriber.full(),
+                    "state": sub.state,
+                }
                 if sub.subscriptionIdentifier is not None:
-                    sub_dict['id'] = sub.subscriptionIdentifier
+                    sub_dict["id"] = sub.subscriptionIdentifier
                 subscriptions[idx] = sub_dict
 
             return subscriptions
@@ -679,19 +1036,20 @@
         # XXX: urllib.urlencode use "&" to separate value, while XMPP URL (cf. RFC 5122)
         #      use ";" as a separator. So if more than one value is used in query_data,
         #      urlencode MUST NOT BE USED.
-        query_data = [('node', node.encode('utf-8'))]
+        query_data = [("node", node.encode("utf-8"))]
         if item is not None:
-            query_data.append(('item', item.encode('utf-8')))
+            query_data.append(("item", item.encode("utf-8")))
         return "xmpp:{service}?;{query}".format(
-            service=service.userhost(),
-            query=urllib.urlencode(query_data)
-            ).decode('utf-8')
+            service=service.userhost(), query=urllib.urlencode(query_data)
+        ).decode("utf-8")
 
     ## methods to manage several stanzas/jids at once ##
 
     # generic #
 
-    def getRTResults(self, session_id, on_success=None, on_error=None, profile=C.PROF_KEY_NONE):
+    def getRTResults(
+        self, session_id, on_success=None, on_error=None, profile=C.PROF_KEY_NONE
+    ):
         return self.rt_sessions.getResults(session_id, on_success, on_error, profile)
 
     def serItemsData(self, items_data, item_cb=lambda item: item.toXml()):
@@ -705,7 +1063,10 @@
         @return (tuple): a serialised form ready to go throught bridge
         """
         items, metadata = items_data
-        return [item_cb(item) for item in items], {key: unicode(value) for key, value in metadata.iteritems()}
+        return (
+            [item_cb(item) for item in items],
+            {key: unicode(value) for key, value in metadata.iteritems()},
+        )
 
     def serItemsDataD(self, items_data, item_cb):
         """Helper method to serialise result from [getItems], deferred version
@@ -719,11 +1080,20 @@
         @return (tuple): a deferred which fire a serialised form ready to go throught bridge
         """
         items, metadata = items_data
+
         def eb(failure):
-            log.warning("Error while serialising/parsing item: {}".format(unicode(failure.value)))
+            log.warning(
+                "Error while serialising/parsing item: {}".format(unicode(failure.value))
+            )
+
         d = defer.gatherResults([item_cb(item).addErrback(eb) for item in items])
+
         def finishSerialisation(serialised_items):
-            return [item for item in serialised_items if item is not None], {key: unicode(value) for key, value in metadata.iteritems()}
+            return (
+                [item for item in serialised_items if item is not None],
+                {key: unicode(value) for key, value in metadata.iteritems()},
+            )
+
         d.addCallback(finishSerialisation)
         return d
 
@@ -739,14 +1109,23 @@
         """
         if failure_result is None:
             failure_result = ()
-        return [('', result) if success else (unicode(result.result) or UNSPECIFIED, failure_result) for success, result in results]
+        return [
+            ("", result)
+            if success
+            else (unicode(result.result) or UNSPECIFIED, failure_result)
+            for success, result in results
+        ]
 
     # subscribe #
 
     def _getNodeSubscriptions(self, service_s, nodeIdentifier, profile_key):
         client = self.host.getClient(profile_key)
-        d = self.getNodeSubscriptions(client, jid.JID(service_s) if service_s else None, nodeIdentifier)
-        d.addCallback(lambda subscriptions: {j.full(): a for j, a in subscriptions.iteritems()})
+        d = self.getNodeSubscriptions(
+            client, jid.JID(service_s) if service_s else None, nodeIdentifier
+        )
+        d.addCallback(
+            lambda subscriptions: {j.full(): a for j, a in subscriptions.iteritems()}
+        )
         return d
 
     def getNodeSubscriptions(self, client, service, nodeIdentifier):
@@ -756,30 +1135,55 @@
         """
         if not nodeIdentifier:
             raise exceptions.DataError("node identifier can't be empty")
-        request = pubsub.PubSubRequest('subscriptionsGet')
+        request = pubsub.PubSubRequest("subscriptionsGet")
         request.recipient = service
         request.nodeIdentifier = nodeIdentifier
 
         def cb(iq_elt):
             try:
-                subscriptions_elt = next(iq_elt.pubsub.elements((pubsub.NS_PUBSUB, 'subscriptions')))
+                subscriptions_elt = next(
+                    iq_elt.pubsub.elements((pubsub.NS_PUBSUB, "subscriptions"))
+                )
             except StopIteration:
-                raise ValueError(_(u"Invalid result: missing <subscriptions> element: {}").format(iq_elt.toXml))
+                raise ValueError(
+                    _(u"Invalid result: missing <subscriptions> element: {}").format(
+                        iq_elt.toXml
+                    )
+                )
             except AttributeError as e:
                 raise ValueError(_(u"Invalid result: {}").format(e))
             try:
-                return {jid.JID(s['jid']): s['subscription'] for s in subscriptions_elt.elements((pubsub.NS_PUBSUB, 'subscription'))}
+                return {
+                    jid.JID(s["jid"]): s["subscription"]
+                    for s in subscriptions_elt.elements(
+                        (pubsub.NS_PUBSUB, "subscription")
+                    )
+                }
             except KeyError:
-                raise ValueError(_(u"Invalid result: bad <subscription> element: {}").format(iq_elt.toXml))
+                raise ValueError(
+                    _(u"Invalid result: bad <subscription> element: {}").format(
+                        iq_elt.toXml
+                    )
+                )
 
         d = request.send(client.xmlstream)
         d.addCallback(cb)
         return d
 
-    def _setNodeSubscriptions(self, service_s, nodeIdentifier, subscriptions, profile_key=C.PROF_KEY_NONE):
+    def _setNodeSubscriptions(
+        self, service_s, nodeIdentifier, subscriptions, profile_key=C.PROF_KEY_NONE
+    ):
         client = self.host.getClient(profile_key)
-        subscriptions = {jid.JID(jid_): subscription for jid_, subscription in subscriptions.iteritems()}
-        d = self.setNodeSubscriptions(client, jid.JID(service_s) if service_s else None, nodeIdentifier, subscriptions)
+        subscriptions = {
+            jid.JID(jid_): subscription
+            for jid_, subscription in subscriptions.iteritems()
+        }
+        d = self.setNodeSubscriptions(
+            client,
+            jid.JID(service_s) if service_s else None,
+            nodeIdentifier,
+            subscriptions,
+        )
         return d
 
     def setNodeSubscriptions(self, client, service, nodeIdentifier, subscriptions):
@@ -788,10 +1192,13 @@
         @param subscriptions(dict[jid.JID, unicode]): subscriptions to set
             check https://xmpp.org/extensions/xep-0060.html#substates for a list of possible subscriptions
         """
-        request = pubsub.PubSubRequest('subscriptionsSet')
+        request = pubsub.PubSubRequest("subscriptionsSet")
         request.recipient = service
         request.nodeIdentifier = nodeIdentifier
-        request.subscriptions = {pubsub.Subscription(nodeIdentifier, jid_, state) for jid_, state in subscriptions.iteritems()}
+        request.subscriptions = {
+            pubsub.Subscription(nodeIdentifier, jid_, state)
+            for jid_, state in subscriptions.iteritems()
+        }
         d = request.send(client.xmlstream)
         return d
 
@@ -808,16 +1215,37 @@
         @param profile_key: %(doc_profile_key)s
         """
         profile = self.host.getClient(profile_key).profile
-        d = self.rt_sessions.getResults(session_id, on_success=lambda result:'', on_error=lambda failure:unicode(failure.value), profile=profile)
+        d = self.rt_sessions.getResults(
+            session_id,
+            on_success=lambda result: "",
+            on_error=lambda failure: unicode(failure.value),
+            profile=profile,
+        )
         # we need to convert jid.JID to unicode with full() to serialise it for the bridge
-        d.addCallback(lambda ret: (ret[0], [(service.full(), node, '' if success else failure or UNSPECIFIED)
-                                            for (service, node), (success, failure) in ret[1].iteritems()]))
+        d.addCallback(
+            lambda ret: (
+                ret[0],
+                [
+                    (service.full(), node, "" if success else failure or UNSPECIFIED)
+                    for (service, node), (success, failure) in ret[1].iteritems()
+                ],
+            )
+        )
         return d
 
-    def _subscribeToMany(self, node_data, subscriber=None, options=None, profile_key=C.PROF_KEY_NONE):
-        return self.subscribeToMany([(jid.JID(service), unicode(node)) for service, node in node_data], jid.JID(subscriber), options, profile_key)
+    def _subscribeToMany(
+        self, node_data, subscriber=None, options=None, profile_key=C.PROF_KEY_NONE
+    ):
+        return self.subscribeToMany(
+            [(jid.JID(service), unicode(node)) for service, node in node_data],
+            jid.JID(subscriber),
+            options,
+            profile_key,
+        )
 
-    def subscribeToMany(self, node_data, subscriber, options=None, profile_key=C.PROF_KEY_NONE):
+    def subscribeToMany(
+        self, node_data, subscriber, options=None, profile_key=C.PROF_KEY_NONE
+    ):
         """Subscribe to several nodes at once.
 
         @param node_data (iterable[tuple]): iterable of tuple (service, node) where:
@@ -831,7 +1259,9 @@
         client = self.host.getClient(profile_key)
         deferreds = {}
         for service, node in node_data:
-            deferreds[(service, node)] = client.pubsub_client.subscribe(service, node, subscriber, options=options)
+            deferreds[(service, node)] = client.pubsub_client.subscribe(
+                service, node, subscriber, options=options
+            )
         return self.rt_sessions.newSession(deferreds, client.profile)
         # found_nodes = yield self.listNodes(service, profile=client.profile)
         # subscribed_nodes = yield self.listSubscribedNodes(service, profile=client.profile)
@@ -860,24 +1290,49 @@
                 - metadata(dict): serialised metadata
         """
         profile = self.host.getClient(profile_key).profile
-        d = self.rt_sessions.getResults(session_id,
-                                        on_success=lambda result: ('', self.serItemsData(result)),
-                                        on_error=lambda failure: (unicode(failure.value) or UNSPECIFIED, ([],{})),
-                                        profile=profile)
-        d.addCallback(lambda ret: (ret[0],
-                                   [(service.full(), node, failure, items, metadata)
-                                    for (service, node), (success, (failure, (items, metadata))) in ret[1].iteritems()]))
+        d = self.rt_sessions.getResults(
+            session_id,
+            on_success=lambda result: ("", self.serItemsData(result)),
+            on_error=lambda failure: (unicode(failure.value) or UNSPECIFIED, ([], {})),
+            profile=profile,
+        )
+        d.addCallback(
+            lambda ret: (
+                ret[0],
+                [
+                    (service.full(), node, failure, items, metadata)
+                    for (service, node), (success, (failure, (items, metadata))) in ret[
+                        1
+                    ].iteritems()
+                ],
+            )
+        )
         return d
 
-    def _getFromMany(self, node_data, max_item=10, extra_dict=None, profile_key=C.PROF_KEY_NONE):
+    def _getFromMany(
+        self, node_data, max_item=10, extra_dict=None, profile_key=C.PROF_KEY_NONE
+    ):
         """
         @param max_item(int): maximum number of item to get, C.NO_LIMIT for no limit
         """
         max_item = None if max_item == C.NO_LIMIT else max_item
         extra = self.parseExtra(extra_dict)
-        return self.getFromMany([(jid.JID(service), unicode(node)) for service, node in node_data], max_item, extra.rsm_request, extra.extra, profile_key)
+        return self.getFromMany(
+            [(jid.JID(service), unicode(node)) for service, node in node_data],
+            max_item,
+            extra.rsm_request,
+            extra.extra,
+            profile_key,
+        )
 
-    def getFromMany(self, node_data, max_item=None, rsm_request=None, extra=None, profile_key=C.PROF_KEY_NONE):
+    def getFromMany(
+        self,
+        node_data,
+        max_item=None,
+        rsm_request=None,
+        extra=None,
+        profile_key=C.PROF_KEY_NONE,
+    ):
         """Get items from many nodes at once
 
         @param node_data (iterable[tuple]): iterable of tuple (service, node) where:
@@ -891,7 +1346,9 @@
         client = self.host.getClient(profile_key)
         deferreds = {}
         for service, node in node_data:
-            deferreds[(service, node)] = self.getItems(client, service, node, max_item, rsm_request=rsm_request, extra=extra)
+            deferreds[(service, node)] = self.getItems(
+                client, service, node, max_item, rsm_request=rsm_request, extra=extra
+            )
         return self.rt_sessions.newSession(deferreds, client.profile)
 
 
@@ -930,7 +1387,13 @@
         client = self.parent
         if (event.sender, event.nodeIdentifier) in client.pubsub_watching:
             raw_items = [i.toXml() for i in event.items]
-            self.host.bridge.psEventRaw(event.sender.full(), event.nodeIdentifier, C.PS_ITEMS, raw_items, client.profile)
+            self.host.bridge.psEventRaw(
+                event.sender.full(),
+                event.nodeIdentifier,
+                C.PS_ITEMS,
+                raw_items,
+                client.profile,
+            )
 
     def deleteReceived(self, event):
         log.debug((u"Publish node deleted"))
@@ -938,7 +1401,9 @@
             callback(self.parent, event)
         client = self.parent
         if (event.sender, event.nodeIdentifier) in client.pubsub_watching:
-            self.host.bridge.psEventRaw(event.sender.full(), event.nodeIdentifier, C.PS_DELETE, [], client.profile)
+            self.host.bridge.psEventRaw(
+                event.sender.full(), event.nodeIdentifier, C.PS_DELETE, [], client.profile
+            )
 
     def subscriptions(self, service, nodeIdentifier, sender=None):
         """Return the list of subscriptions to the given service and node.
@@ -949,7 +1414,7 @@
         @type nodeIdentifier: C{unicode}
         @return (list[pubsub.Subscription]): list of subscriptions
         """
-        request = pubsub.PubSubRequest('subscriptions')
+        request = pubsub.PubSubRequest("subscriptions")
         request.recipient = service
         request.nodeIdentifier = nodeIdentifier
         request.sender = sender
@@ -957,20 +1422,24 @@
 
         def cb(iq):
             subs = []
-            for subscription_elt in iq.pubsub.subscriptions.elements(pubsub.NS_PUBSUB, 'subscription'):
-                subscription = pubsub.Subscription(subscription_elt['node'],
-                                                   jid.JID(subscription_elt['jid']),
-                                                   subscription_elt['subscription'],
-                                                   subscriptionIdentifier=subscription_elt.getAttribute('subid'))
+            for subscription_elt in iq.pubsub.subscriptions.elements(
+                pubsub.NS_PUBSUB, "subscription"
+            ):
+                subscription = pubsub.Subscription(
+                    subscription_elt["node"],
+                    jid.JID(subscription_elt["jid"]),
+                    subscription_elt["subscription"],
+                    subscriptionIdentifier=subscription_elt.getAttribute("subid"),
+                )
                 subs.append(subscription)
             return subs
 
         return d.addCallback(cb)
 
-    def getDiscoInfo(self, requestor, service, nodeIdentifier=''):
+    def getDiscoInfo(self, requestor, service, nodeIdentifier=""):
         disco_info = []
         self.host.trigger.point("PubSub Disco Info", disco_info, self.parent.profile)
         return disco_info
 
-    def getDiscoItems(self, requestor, service, nodeIdentifier=''):
+    def getDiscoItems(self, requestor, service, nodeIdentifier=""):
         return []