Mercurial > libervia-backend

diff libervia/backend/plugins/plugin_xep_0048.py @ 4212:5f2d496c633f

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
core: get rid of `pickle`: Use of `pickle` to serialise data was a technical legacy that was causing trouble to store in database, to update (if a class was serialised, a change could break update), and to security (pickle can lead to code execution). This patch remove all use of Pickle in favour in JSON, notably: - for caching data, a Pydantic model is now used instead - for SQLAlchemy model, the LegacyPickle is replaced by JSON serialisation - in XEP-0373 a class `PublicKeyMetadata` was serialised. New method `from_dict` and `to_dict` method have been implemented to do serialisation. - new methods to (de)serialise data can now be specified with Identity data types. It is notably used to (de)serialise `path` of avatars. A migration script has been created to convert data (for upgrade or downgrade), with special care for XEP-0373 case. Depending of size of database, this migration script can be long to run. rel 443
author Goffi <goffi@goffi.org>
date Fri, 23 Feb 2024 13:31:04 +0100
parents 4b842c1fb686
children 3fbd1a1285c1
line wrap: on
line diff
--- a/libervia/backend/plugins/plugin_xep_0048.py	Fri Feb 16 18:46:06 2024 +0100
+++ b/libervia/backend/plugins/plugin_xep_0048.py	Fri Feb 23 13:31:04 2024 +0100
@@ -17,6 +17,7 @@
 # You should have received a copy of the GNU Affero General Public License
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
+from typing import cast
 from libervia.backend.core.i18n import _, D_
 from libervia.backend.core import exceptions
 from libervia.backend.core.constants import Const as C
@@ -106,9 +107,12 @@
             NS_BOOKMARKS, client.profile
         )
         await local.load()
+        local = cast(dict[str, dict|None]|None, local)
         if not local:
-            local[XEP_0048.MUC_TYPE] = dict()
-            local[XEP_0048.URL_TYPE] = dict()
+            local = {
+                XEP_0048.MUC_TYPE: {},
+                XEP_0048.URL_TYPE: {}
+            }
         private = await self._get_server_bookmarks("private", client.profile)
         pubsub = client.bookmarks_pubsub = None