diff sat/bridge/bridge_constructor/constructors/dbus/dbus_core_template.py @ 3028:ab2696e34d29

Python 3 port: /!\ this is a huge commit /!\ starting from this commit, SàT is needs Python 3.6+ /!\ SàT maybe be instable or some feature may not work anymore, this will improve with time This patch port backend, bridge and frontends to Python 3. Roughly this has been done this way: - 2to3 tools has been applied (with python 3.7) - all references to python2 have been replaced with python3 (notably shebangs) - fixed files not handled by 2to3 (notably the shell script) - several manual fixes - fixed issues reported by Python 3 that where not handled in Python 2 - replaced "async" with "async_" when needed (it's a reserved word from Python 3.7) - replaced zope's "implements" with @implementer decorator - temporary hack to handle data pickled in database, as str or bytes may be returned, to be checked later - fixed hash comparison for password - removed some code which is not needed anymore with Python 3 - deactivated some code which needs to be checked (notably certificate validation) - tested with jp, fixed reported issues until some basic commands worked - ported Primitivus (after porting dependencies like urwid satext) - more manual fixes
author Goffi <goffi@goffi.org>
date Tue, 13 Aug 2019 19:08:41 +0200
parents 003b8b4b56a7
children 9d0df638c8b4
line wrap: on
line diff
--- a/sat/bridge/bridge_constructor/constructors/dbus/dbus_core_template.py	Wed Jul 31 11:31:22 2019 +0200
+++ b/sat/bridge/bridge_constructor/constructors/dbus/dbus_core_template.py	Tue Aug 13 19:08:41 2019 +0200
@@ -1,4 +1,4 @@
-#!/usr/bin/env python2
+#!/usr/bin/env python3
 # -*- coding: utf-8 -*-
 
 # SAT: a jabber client
@@ -101,11 +101,11 @@
                 raise InternalError
             callback = kwargs.pop("callback")
             errback = kwargs.pop("errback")
-            async = True
+            async_ = True
         else:
-            async = False
+            async_ = False
         result = self.cb[name](*args, **kwargs)
-        if async:
+        if async_:
             if not isinstance(result, Deferred):
                 log.error("Asynchronous method [%s] does not return a Deferred." % name)
                 raise AsyncNotDeferred
@@ -170,9 +170,9 @@
             i += 1
         return attr
 
-    def addMethod(self, name, int_suffix, in_sign, out_sign, method, async=False):
+    def addMethod(self, name, int_suffix, in_sign, out_sign, method, async_=False):
         """Dynamically add a method to Dbus Bridge"""
-        inspect_args = inspect.getargspec(method)
+        inspect_args = inspect.getfullargspec(method)
 
         _arguments = inspect_args.args
         _defaults = list(inspect_args.defaults or [])
@@ -186,12 +186,12 @@
             [repr(name)]
             + (
                 (_arguments + ["callback=callback", "errback=errback"])
-                if async
+                if async_
                 else _arguments
             )
         )
 
-        if async:
+        if async_:
             _arguments.extend(["callback", "errback"])
             _defaults.extend([None, None])
 
@@ -213,7 +213,7 @@
         )
         exec(code)  # FIXME: to the same thing in a cleaner way, without compile/exec
         method = locals()[name]
-        async_callbacks = ("callback", "errback") if async else None
+        async_callbacks = ("callback", "errback") if async_ else None
         setattr(
             DbusObject,
             name,
@@ -265,7 +265,7 @@
             if e._dbus_error_name == "org.freedesktop.DBus.Error.NotSupported":
                 log.error(
                     _(
-                        u"D-Bus is not launched, please see README to see instructions on how to launch it"
+                        "D-Bus is not launched, please see README to see instructions on how to launch it"
                     )
                 )
             raise BridgeInitError
@@ -277,11 +277,11 @@
         log.debug("registering DBus bridge method [%s]" % name)
         self.dbus_bridge.register_method(name, callback)
 
-    def addMethod(self, name, int_suffix, in_sign, out_sign, method, async=False, doc={}):
+    def addMethod(self, name, int_suffix, in_sign, out_sign, method, async_=False, doc={}):
         """Dynamically add a method to Dbus Bridge"""
         # FIXME: doc parameter is kept only temporary, the time to remove it from calls
         log.debug("Adding method [%s] to DBus bridge" % name)
-        self.dbus_bridge.addMethod(name, int_suffix, in_sign, out_sign, method, async)
+        self.dbus_bridge.addMethod(name, int_suffix, in_sign, out_sign, method, async_)
         self.register_method(name, method)
 
     def addSignal(self, name, int_suffix, signature, doc={}):