Mercurial > libervia-backend

diff libervia/backend/plugins/plugin_xep_0167/mapping.py @ 4231:e11b13418ba6

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
plugin XEP-0353, XEP-0234, jingle: WebRTC data channel signaling implementation: Implement XEP-0343: Signaling WebRTC Data Channels in Jingle. The current version of the XEP (0.3.1) has no implementation and contains some flaws. After discussing this on xsf@, Daniel (from Conversations) mentioned that they had a sprint with Larma (from Dino) to work on another version and provided me with this link: https://gist.github.com/iNPUTmice/6c56f3e948cca517c5fb129016d99e74 . I have used it for my implementation. This implementation reuses work done on Jingle A/V call (notably XEP-0176 and XEP-0167 plugins), with adaptations. When used, XEP-0234 will not handle the file itself as it normally does. This is because WebRTC has several implementations (browser for web interface, GStreamer for others), and file/data must be handled directly by the frontend. This is particularly important for web frontends, as the file is not sent from the backend but from the end-user's browser device. Among the changes, there are: - XEP-0343 implementation. - `file_send` bridge method now use serialised dict as output. - New `BaseTransportHandler.is_usable` method which get content data and returns a boolean (default to `True`) to tell if this transport can actually be used in this context (when we are initiator). Used in webRTC case to see if call data are available. - Support of `application` media type, and everything necessary to handle data channels. - Better confirmation message, with file name, size and description when available. - When file is accepted in preflight, it is specified in following `action_new` signal for actual file transfer. This way, frontend can avoid the display or 2 confirmation messages. - XEP-0166: when not specified, default `content` name is now its index number instead of a UUID. This follows the behaviour of browsers. - XEP-0353: better handling of events such as call taken by another device. - various other updates. rel 441
author Goffi <goffi@goffi.org>
date Sat, 06 Apr 2024 12:57:23 +0200
parents b2709504586a
children 79c8a70e1813
line wrap: on
line diff
--- a/libervia/backend/plugins/plugin_xep_0167/mapping.py	Sat Apr 06 12:21:04 2024 +0200
+++ b/libervia/backend/plugins/plugin_xep_0167/mapping.py	Sat Apr 06 12:57:23 2024 +0200
@@ -122,9 +122,13 @@
         payload_types = media_data.get("payload_types", {})
 
         # Generate m= line
-        transport = "UDP/TLS/RTP/SAVPF"
-        payload_type_ids = [str(pt_id) for pt_id in payload_types]
-        m_line = f"m={media} {port} {transport} {' '.join(payload_type_ids)}"
+        if media == "application":
+            transport = "UDP/DTLS/SCTP"
+            m_line = f"m={media} {port} {transport} webrtc-datachannel"
+        else:
+            transport = "UDP/TLS/RTP/SAVPF"
+            payload_type_ids = [str(pt_id) for pt_id in payload_types]
+            m_line = f"m={media} {port} {transport} {' '.join(payload_type_ids)}"
         sdp_lines.append(m_line)
 
         sdp_lines.append(f"c={network_type} {address_type} {connection_address}")
@@ -269,12 +273,18 @@
             if prefix == "m=":
                 media_type = parts[0]
                 port = int(parts[1])
-                payload_types = {}
-                for payload_type_id in [int(pt_id) for pt_id in parts[3:]]:
-                    payload_type = {"id": payload_type_id}
-                    payload_types[payload_type_id] = payload_type
+                application_data = {"media": media_type}
+                if media_type in ("video", "audio"):
+                    payload_types = application_data["payload_types"] = {}
+                    for payload_type_id in [int(pt_id) for pt_id in parts[3:]]:
+                        payload_type = {"id": payload_type_id}
+                        payload_types[payload_type_id] = payload_type
+                elif media_type == "application":
+                    if parts[3] != "webrtc-datachannel":
+                        raise NotImplementedError(
+                            f"{media_type!r} application is not supported"
+                        )
 
-                application_data = {"media": media_type, "payload_types": payload_types}
                 transport_data = {"port": port}
                 if fingerprint_data is not None:
                     transport_data["fingerprint"] = fingerprint_data