diff sat_frontends/jp/cmd_ping.py @ 3040:fee60f17ebac

jp: jp asyncio port: /!\ this commit is huge. Jp is temporarily not working with `dbus` bridge /!\ This patch implements the port of jp to asyncio, so it is now correctly using the bridge asynchronously, and it can be used with bridges like `pb`. This also simplify the code, notably for things which were previously implemented with many callbacks (like pagination with RSM). During the process, some behaviours have been modified/fixed, in jp and backends, check diff for details.
author Goffi <goffi@goffi.org>
date Wed, 25 Sep 2019 08:56:41 +0200
parents ab2696e34d29
children 9d0df638c8b4
line wrap: on
line diff
--- a/sat_frontends/jp/cmd_ping.py	Wed Sep 25 08:53:38 2019 +0200
+++ b/sat_frontends/jp/cmd_ping.py	Wed Sep 25 08:56:41 2019 +0200
@@ -19,6 +19,7 @@
 
 from . import base
 from sat.core.i18n import _
+from sat_frontends.jp.constants import Const as C
 
 __commands__ = ["Ping"]
 
@@ -27,7 +28,6 @@
 
     def __init__(self, host):
         super(Ping, self).__init__(host, 'ping', help=_('ping XMPP entity'))
-        self.need_loop=True
 
     def add_parser_options(self):
         self.parser.add_argument(
@@ -37,11 +37,13 @@
             "-d", "--delay-only", action="store_true", help=_("output delay only (in s)")
         )
 
-    def _pingCb(self, pong_time):
-        fmt = "{time}" if self.args.delay_only else  "PONG ({time} s)"
-        self.disp(fmt.format(time=pong_time))
-        self.host.quit()
-
-    def start(self):
-        self.host.bridge.ping(self.args.jid, self.profile,
-            callback=self._pingCb, errback=self.errback)
+    async def start(self):
+        try:
+            pong_time = await self.host.bridge.ping(self.args.jid, self.profile)
+        except Exception as e:
+            self.disp(msg=_(f"can't do the ping: {e}"), error=True)
+            self.host.quit(C.EXIT_BRIDGE_ERRBACK)
+        else:
+            msg = pong_time if self.args.delay_only else  f"PONG ({pong_time} s)"
+            self.disp(msg)
+            self.host.quit()