# HG changeset patch
# User Goffi <goffi@goffi.org>
# Date 1282123635 -28800
# Node ID 12544ea2951fe84bcc7faad76cbc751f2f4bac37
# Parent  33e618d385cf55badf3aa2e58e7115a88fb99176
Core: removed addItem for roster list, according to http://wokkel.ik.nu/ticket/56

diff -r 33e618d385cf -r 12544ea2951f sat.tac
--- a/sat.tac	Wed Aug 18 17:26:34 2010 +0800
+++ b/sat.tac	Wed Aug 18 17:27:15 2010 +0800
@@ -153,10 +153,11 @@
         xmppim.RosterClientProtocol.removeItem(self, to)
         #TODO: check IQ result
     
-    def addItem(self, to):
-        """Add a contact to roster list"""
-        xmppim.RosterClientProtocol.addItem(self, to)
-        #TODO: check IQ result
+    #XXX: disabled (cf http://wokkel.ik.nu/ticket/56))
+    #def addItem(self, to):
+        #"""Add a contact to roster list"""
+        #xmppim.RosterClientProtocol.addItem(self, to)
+        #TODO: check IQ result"""
 
     def onRosterSet(self, item):
         """Called when a new/update roster item is received"""
@@ -608,7 +609,10 @@
         self.profiles[profile].presence.available(to_jid, show, statuses, priority)
     
     def subscription(self, subs_type, raw_jid, profile_key='@DEFAULT@'):
-        """Called to manage subscription"""
+        """Called to manage subscription
+        @param subs_type: subsciption type (cf RFC 3921)
+        @param raw_jid: unicode entity's jid
+        @param profile_key: profile"""
         profile = self.memory.getProfileName(profile_key)
         assert(profile)
         to_jid = jid.JID(raw_jid)
@@ -632,7 +636,7 @@
         profile = self.memory.getProfileName(profile_key)
         assert(profile)
         to_jid=jid.JID(to)
-        self.profiles[profile].roster.addItem(to_jid)
+        #self.profiles[profile].roster.addItem(to_jid) XXX: disabled (cf http://wokkel.ik.nu/ticket/56))
         self.profiles[profile].presence.subscribe(to_jid)
 
     def delContact(self, to, profile_key='@DEFAULT@'):