# HG changeset patch # User Goffi # Date 1622819924 -7200 # Node ID 13e7ef10658992e693a60cb5233f00076a10bd59 # Parent 1ac5570fa998b19c7045e6f7a983273dc9eb4a79 plugin XEP-0277: don't wrap `DataError` in `failure.Failure` in `parseCommentUrl` as it is not catched correctly: `failure.Failure` is subclass of `BaseException` but not of `Exception`, as a result `except Exception` doesn't catch it correctly. This is fixed by not wrapping `DataError` in `failure.Failure` anymore. diff -r 1ac5570fa998 -r 13e7ef106589 sat/plugins/plugin_xep_0277.py --- a/sat/plugins/plugin_xep_0277.py Fri Jun 04 15:23:24 2021 +0200 +++ b/sat/plugins/plugin_xep_0277.py Fri Jun 04 17:18:44 2021 +0200 @@ -1005,7 +1005,7 @@ node = parsed_queries.get("node", [""])[0] if not node: - raise failure.Failure(exceptions.DataError("Invalid comments link")) + raise exceptions.DataError("Invalid comments link") return (service, node)