# HG changeset patch
# User Goffi <goffi@goffi.org>
# Date 1696341621 -7200
# Node ID c8b19a32f5c0463e28d3b201d818ab7bb635d5b3
# Parent  52a89ddf3087b5430b6002180c654ff5d7236ffc
plugin XEP-0338: always add `<group>` element as first <jingle> child:

this is to work around a Movim bug (https://github.com/movim/movim/issues/1233).

rel 424

diff -r 52a89ddf3087 -r c8b19a32f5c0 libervia/backend/plugins/plugin_xep_0338.py
--- a/libervia/backend/plugins/plugin_xep_0338.py	Tue Oct 03 15:27:07 2023 +0200
+++ b/libervia/backend/plugins/plugin_xep_0338.py	Tue Oct 03 16:00:21 2023 +0200
@@ -109,7 +109,11 @@
     ) -> None:
         """Build the <group> and <content> elements if possible"""
         for semantics, content_names in session["metadata"].get("group", {}).items():
-            group_elt = jingle_elt.addElement((NS_JINGLE_GROUPING, "group"))
+            # always add the <group> element as first child of <jingle> element to work
+            # around https://github.com/movim/movim/issues/1233
+            group_elt = domish.Element((NS_JINGLE_GROUPING, "group"))
+            jingle_elt.children.insert(0, group_elt)
+
             group_elt["semantics"] = semantics
             for content_name in content_names:
                 content_elt = group_elt.addElement((NS_JINGLE_GROUPING, "content"))