# HG changeset patch # User Goffi # Date 1643127212 -3600 # Node ID 6878745a47e810cc90c905d3d4e5f4f3c1980992 # Parent 40a6374fcd44f80b5309ce66cad2268cae40052a component file sharing: fix incorrect use of `returnValue` in `items` async method diff -r 40a6374fcd44 -r 6878745a47e8 sat/plugins/plugin_comp_file_sharing.py --- a/sat/plugins/plugin_comp_file_sharing.py Tue Jan 25 17:09:54 2022 +0100 +++ b/sat/plugins/plugin_comp_file_sharing.py Tue Jan 25 17:13:32 2022 +0100 @@ -814,7 +814,7 @@ continue def _getFrom(self, item_elt): - """retrieve published of an item + """retrieve publisher of an item @param item_elt(domish.element): element @return (unicode): full jid as string @@ -845,9 +845,7 @@ file_data = await self.getFileData(requestor, nodeIdentifier) comments = file_data["extra"].get("comments", []) if itemIdentifiers: - defer.returnValue( - [generic.parseXml(c[2]) for c in comments if c[0] in itemIdentifiers] - ) + return [generic.parseXml(c[2]) for c in comments if c[0] in itemIdentifiers] else: return [generic.parseXml(c[2]) for c in comments]