# HG changeset patch
# User Goffi <goffi@goffi.org>
# Date 1580151211 -3600
# Node ID 95befc85e816be0bd40ad89330ac7aae3d1324b5
# Parent  73b5228715e844c5247e6b9adf990871cb5dd814
plugin XEP-0184: show a warning and the message XML on missing `id`

diff -r 73b5228715e8 -r 95befc85e816 sat/plugins/plugin_xep_0184.py
--- a/sat/plugins/plugin_xep_0184.py	Mon Jan 27 19:52:49 2020 +0100
+++ b/sat/plugins/plugin_xep_0184.py	Mon Jan 27 19:53:31 2020 +0100
@@ -152,7 +152,11 @@
 
         if self._isActif(client.profile) and client.roster.isPresenceAuthorised(from_jid):
             received_elt_ret = domish.Element((NS_MESSAGE_DELIVERY_RECEIPTS, "received"))
-            received_elt_ret["id"] = msg_elt["id"]
+            try:
+                received_elt_ret["id"] = msg_elt["id"]
+            except KeyError:
+                log.warning(f"missing id for message element: {msg_elt.toXml}")
+                return
 
             msg_result_elt = xmlstream.toResponse(msg_elt, "result")
             msg_result_elt.addChild(received_elt_ret)