# HG changeset patch
# User Goffi <goffi@goffi.org>
# Date 1552332244 -3600
# Node ID 896f78760b63cd935680f8488a014f48dfe78ce8
# Parent  b3f97729e9834933deb46880b409c6273f7977a8
core: fixed crash when calling deleteUnusedWidgetInstances on widgets not inheriting from QuickWidget

diff -r b3f97729e983 -r 896f78760b63 cagou/core/cagou_main.py
--- a/cagou/core/cagou_main.py	Mon Mar 11 08:39:43 2019 +0100
+++ b/cagou/core/cagou_main.py	Mon Mar 11 20:24:04 2019 +0100
@@ -774,12 +774,13 @@
         """
         # FIXME: unused for now
         to_delete = []
-        for w in self.widgets.getWidgetInstances(widget):
-            if w.parent is None and w != widget:
-                to_delete.append(w)
-        for w in to_delete:
-            log.debug(u"cleaning widget: {wid}".format(wid=w))
-            self.widgets.deleteWidget(w)
+        if isinstance(widget, quick_widgets.QuickWidget):
+            for w in self.widgets.getWidgetInstances(widget):
+                if w.parent is None and w != widget:
+                    to_delete.append(w)
+            for w in to_delete:
+                log.debug(u"cleaning widget: {wid}".format(wid=w))
+                self.widgets.deleteWidget(w)
 
     def getOrClone(self, widget):
         """Get a QuickWidget if it has not parent set else clone it
diff -r b3f97729e983 -r 896f78760b63 cagou/plugins/plugin_wid_widget_selector.py
--- a/cagou/plugins/plugin_wid_widget_selector.py	Mon Mar 11 08:39:43 2019 +0100
+++ b/cagou/plugins/plugin_wid_widget_selector.py	Mon Mar 11 20:24:04 2019 +0100
@@ -50,6 +50,7 @@
 
 
 class WidgetSelector(cagou_widget.CagouWidget):
+    # TODO: should inherit from QuickWidget
 
     def __init__(self):
         super(WidgetSelector, self).__init__()