Mercurial > libervia-web
annotate libervia/server/tasks/manager.py @ 1251:a1606e2a92eb
server: fixed watching a directory which is already watched:
Twisted file watched is not adding a callback to a watched path when there is already one,
but this can happens often in Libervia, as a whole site is recusively watched in dev mode,
and tasks may want to add other watchers.
To work around this, the new `_checkCallback` will recursively check that callback has
been indeed added to the requested path.
| author | Goffi <goffi@goffi.org> |
|---|---|
| date | Wed, 29 Apr 2020 14:54:33 +0200 |
| parents | a6c7f07f1e4d |
| children | 80a92eb82b7f |
| rev | line source |
|---|---|
| 1239 | 1 #!/usr/bin/env python3 |
| 2 | |
| 1146 | 3 # Libervia: a Salut à Toi frontend |
| 1237 | 4 # Copyright (C) 2011-2020 Jérôme Poisson <goffi@goffi.org> |
| 1146 | 5 |
| 6 # This program is free software: you can redistribute it and/or modify | |
| 7 # it under the terms of the GNU Affero General Public License as published by | |
| 8 # the Free Software Foundation, either version 3 of the License, or | |
| 9 # (at your option) any later version. | |
| 10 | |
| 11 # This program is distributed in the hope that it will be useful, | |
| 12 # but WITHOUT ANY WARRANTY; without even the implied warranty of | |
| 13 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | |
| 14 # GNU Affero General Public License for more details. | |
| 15 | |
| 16 # You should have received a copy of the GNU Affero General Public License | |
| 17 # along with this program. If not, see <http://www.gnu.org/licenses/>. | |
| 18 import os | |
| 19 import os.path | |
|
1247
a6c7f07f1e4d
tasks: implicit tasks + Brython task:
Goffi <goffi@goffi.org>
parents:
1245
diff
changeset
|
20 from pathlib import Path |
| 1245 | 21 import importlib.util |
|
1247
a6c7f07f1e4d
tasks: implicit tasks + Brython task:
Goffi <goffi@goffi.org>
parents:
1245
diff
changeset
|
22 from twisted.internet import defer |
| 1245 | 23 from sat.core.log import getLogger |
| 1146 | 24 from sat.core import exceptions |
| 25 from sat.core.i18n import _ | |
| 1245 | 26 from sat.tools import utils |
| 1146 | 27 from libervia.server.constants import Const as C |
|
1247
a6c7f07f1e4d
tasks: implicit tasks + Brython task:
Goffi <goffi@goffi.org>
parents:
1245
diff
changeset
|
28 from . import implicit |
| 1146 | 29 |
| 30 log = getLogger(__name__) | |
| 31 | |
| 32 | |
| 1245 | 33 class TasksManager: |
| 1146 | 34 """Handle tasks of a Libervia site""" |
| 35 | |
| 36 def __init__(self, host, site_resource): | |
| 37 """ | |
| 38 @param site_resource(LiberviaRootResource): root resource of the site to manage | |
| 39 """ | |
| 40 self.host = host | |
| 41 self.resource = site_resource | |
|
1247
a6c7f07f1e4d
tasks: implicit tasks + Brython task:
Goffi <goffi@goffi.org>
parents:
1245
diff
changeset
|
42 self.tasks_dir = self.site_path / C.TASKS_DIR |
| 1245 | 43 self.tasks = {} |
| 1146 | 44 self._build_path = None |
| 45 self._current_task = None | |
| 46 | |
| 47 @property | |
| 48 def site_path(self): | |
|
1247
a6c7f07f1e4d
tasks: implicit tasks + Brython task:
Goffi <goffi@goffi.org>
parents:
1245
diff
changeset
|
49 return Path(self.resource.site_path) |
| 1146 | 50 |
| 51 @property | |
| 52 def build_path(self): | |
| 53 """path where generated files will be build for this site""" | |
| 54 if self._build_path is None: | |
| 55 self._build_path = self.host.getBuildPath(self.site_name) | |
| 56 return self._build_path | |
| 57 | |
| 58 @property | |
| 59 def site_name(self): | |
| 60 return self.resource.site_name | |
| 61 | |
| 1245 | 62 def validateData(self, task): |
| 63 """Check workflow attributes in task""" | |
| 1146 | 64 |
| 1245 | 65 for var, allowed in (("ON_ERROR", ("continue", "stop")), |
| 66 ("LOG_OUTPUT", bool), | |
| 67 ("WATCH_DIRS", list)): | |
| 68 value = getattr(task, var) | |
| 1146 | 69 |
| 70 if isinstance(allowed, type): | |
| 1245 | 71 if allowed is list and value is None: |
| 72 continue | |
| 1146 | 73 if not isinstance(value, allowed): |
| 74 raise ValueError( | |
| 1216 | 75 _("Unexpected value for {var}, {allowed} is expected.") |
| 1245 | 76 .format(var=var, allowed=allowed)) |
| 1146 | 77 else: |
| 78 if not value in allowed: | |
| 1245 | 79 raise ValueError(_("Unexpected value for {var}: {value!r}").format( |
| 80 var=var, value=value)) | |
| 1146 | 81 |
|
1247
a6c7f07f1e4d
tasks: implicit tasks + Brython task:
Goffi <goffi@goffi.org>
parents:
1245
diff
changeset
|
82 async def parseTasksDir(self, dir_path): |
|
a6c7f07f1e4d
tasks: implicit tasks + Brython task:
Goffi <goffi@goffi.org>
parents:
1245
diff
changeset
|
83 log.debug(f"parsing tasks in {dir_path}") |
|
a6c7f07f1e4d
tasks: implicit tasks + Brython task:
Goffi <goffi@goffi.org>
parents:
1245
diff
changeset
|
84 tasks_paths = sorted(dir_path.glob('task_*.py')) |
|
a6c7f07f1e4d
tasks: implicit tasks + Brython task:
Goffi <goffi@goffi.org>
parents:
1245
diff
changeset
|
85 for task_path in tasks_paths: |
|
a6c7f07f1e4d
tasks: implicit tasks + Brython task:
Goffi <goffi@goffi.org>
parents:
1245
diff
changeset
|
86 if not task_path.is_file(): |
| 1146 | 87 continue |
|
1247
a6c7f07f1e4d
tasks: implicit tasks + Brython task:
Goffi <goffi@goffi.org>
parents:
1245
diff
changeset
|
88 task_name = task_path.stem[5:].lower().strip() |
| 1146 | 89 if not task_name: |
| 90 continue | |
| 91 if task_name in self.tasks: | |
| 92 raise exceptions.ConflictError( | |
| 1216 | 93 "A task with the name [{name}] already exists".format( |
| 1146 | 94 name=task_name)) |
|
1247
a6c7f07f1e4d
tasks: implicit tasks + Brython task:
Goffi <goffi@goffi.org>
parents:
1245
diff
changeset
|
95 log.debug(f"task {task_name} found") |
| 1245 | 96 module_name = f"{self.site_name}.task.{task_name}" |
| 97 | |
|
1247
a6c7f07f1e4d
tasks: implicit tasks + Brython task:
Goffi <goffi@goffi.org>
parents:
1245
diff
changeset
|
98 spec = importlib.util.spec_from_file_location(module_name, task_path) |
| 1245 | 99 task_module = importlib.util.module_from_spec(spec) |
| 100 spec.loader.exec_module(task_module) | |
| 101 task = task_module.Task(self) | |
| 102 | |
|
1154
a1625e68b726
server (tasks): task can now use a "prepare" method to prepare data before running (e.g. WATCH_DIRS)
Goffi <goffi@goffi.org>
parents:
1147
diff
changeset
|
103 # we launch prepare, which is a method used to prepare |
|
a1625e68b726
server (tasks): task can now use a "prepare" method to prepare data before running (e.g. WATCH_DIRS)
Goffi <goffi@goffi.org>
parents:
1147
diff
changeset
|
104 # data at runtime (e.g. set WATCH_DIRS using config) |
|
a1625e68b726
server (tasks): task can now use a "prepare" method to prepare data before running (e.g. WATCH_DIRS)
Goffi <goffi@goffi.org>
parents:
1147
diff
changeset
|
105 try: |
| 1245 | 106 prepare = task.prepare |
| 107 except AttributeError: | |
|
1154
a1625e68b726
server (tasks): task can now use a "prepare" method to prepare data before running (e.g. WATCH_DIRS)
Goffi <goffi@goffi.org>
parents:
1147
diff
changeset
|
108 pass |
|
a1625e68b726
server (tasks): task can now use a "prepare" method to prepare data before running (e.g. WATCH_DIRS)
Goffi <goffi@goffi.org>
parents:
1147
diff
changeset
|
109 else: |
|
1247
a6c7f07f1e4d
tasks: implicit tasks + Brython task:
Goffi <goffi@goffi.org>
parents:
1245
diff
changeset
|
110 try: |
|
a6c7f07f1e4d
tasks: implicit tasks + Brython task:
Goffi <goffi@goffi.org>
parents:
1245
diff
changeset
|
111 await utils.asDeferred(prepare) |
|
a6c7f07f1e4d
tasks: implicit tasks + Brython task:
Goffi <goffi@goffi.org>
parents:
1245
diff
changeset
|
112 except exceptions.CancelError as e: |
|
a6c7f07f1e4d
tasks: implicit tasks + Brython task:
Goffi <goffi@goffi.org>
parents:
1245
diff
changeset
|
113 log.debug(f"Skipping {task_name} which cancelled itself: {e}") |
|
a6c7f07f1e4d
tasks: implicit tasks + Brython task:
Goffi <goffi@goffi.org>
parents:
1245
diff
changeset
|
114 continue |
|
a6c7f07f1e4d
tasks: implicit tasks + Brython task:
Goffi <goffi@goffi.org>
parents:
1245
diff
changeset
|
115 |
|
a6c7f07f1e4d
tasks: implicit tasks + Brython task:
Goffi <goffi@goffi.org>
parents:
1245
diff
changeset
|
116 self.tasks[task_name] = task |
| 1245 | 117 self.validateData(task) |
|
1155
813d54af8c0c
server (tasks): tasks can now be automatically ran when something happen in a watched dir:
Goffi <goffi@goffi.org>
parents:
1154
diff
changeset
|
118 if self.host.options['dev_mode']: |
| 1245 | 119 dirs = task.WATCH_DIRS or [] |
|
1155
813d54af8c0c
server (tasks): tasks can now be automatically ran when something happen in a watched dir:
Goffi <goffi@goffi.org>
parents:
1154
diff
changeset
|
120 for dir_ in dirs: |
|
813d54af8c0c
server (tasks): tasks can now be automatically ran when something happen in a watched dir:
Goffi <goffi@goffi.org>
parents:
1154
diff
changeset
|
121 self.host.files_watcher.watchDir( |
|
813d54af8c0c
server (tasks): tasks can now be automatically ran when something happen in a watched dir:
Goffi <goffi@goffi.org>
parents:
1154
diff
changeset
|
122 dir_, auto_add=True, recursive=True, |
|
813d54af8c0c
server (tasks): tasks can now be automatically ran when something happen in a watched dir:
Goffi <goffi@goffi.org>
parents:
1154
diff
changeset
|
123 callback=self._autorunTask, task_name=task_name) |
|
813d54af8c0c
server (tasks): tasks can now be automatically ran when something happen in a watched dir:
Goffi <goffi@goffi.org>
parents:
1154
diff
changeset
|
124 |
|
1247
a6c7f07f1e4d
tasks: implicit tasks + Brython task:
Goffi <goffi@goffi.org>
parents:
1245
diff
changeset
|
125 async def parseTasks(self): |
|
a6c7f07f1e4d
tasks: implicit tasks + Brython task:
Goffi <goffi@goffi.org>
parents:
1245
diff
changeset
|
126 # implicit tasks are always run |
|
a6c7f07f1e4d
tasks: implicit tasks + Brython task:
Goffi <goffi@goffi.org>
parents:
1245
diff
changeset
|
127 implicit_path = Path(implicit.__file__).parent |
|
a6c7f07f1e4d
tasks: implicit tasks + Brython task:
Goffi <goffi@goffi.org>
parents:
1245
diff
changeset
|
128 await self.parseTasksDir(implicit_path) |
|
a6c7f07f1e4d
tasks: implicit tasks + Brython task:
Goffi <goffi@goffi.org>
parents:
1245
diff
changeset
|
129 # now we check if there are tasks specific to this site |
|
a6c7f07f1e4d
tasks: implicit tasks + Brython task:
Goffi <goffi@goffi.org>
parents:
1245
diff
changeset
|
130 if not self.tasks_dir.is_dir(): |
|
a6c7f07f1e4d
tasks: implicit tasks + Brython task:
Goffi <goffi@goffi.org>
parents:
1245
diff
changeset
|
131 log.debug(_("{name} has no task to launch.").format( |
|
a6c7f07f1e4d
tasks: implicit tasks + Brython task:
Goffi <goffi@goffi.org>
parents:
1245
diff
changeset
|
132 name = self.resource.site_name or "default site")) |
|
a6c7f07f1e4d
tasks: implicit tasks + Brython task:
Goffi <goffi@goffi.org>
parents:
1245
diff
changeset
|
133 return |
|
a6c7f07f1e4d
tasks: implicit tasks + Brython task:
Goffi <goffi@goffi.org>
parents:
1245
diff
changeset
|
134 else: |
|
a6c7f07f1e4d
tasks: implicit tasks + Brython task:
Goffi <goffi@goffi.org>
parents:
1245
diff
changeset
|
135 await self.parseTasksDir(self.tasks_dir) |
|
a6c7f07f1e4d
tasks: implicit tasks + Brython task:
Goffi <goffi@goffi.org>
parents:
1245
diff
changeset
|
136 |
|
1155
813d54af8c0c
server (tasks): tasks can now be automatically ran when something happen in a watched dir:
Goffi <goffi@goffi.org>
parents:
1154
diff
changeset
|
137 def _autorunTask(self, host, filepath, flags, task_name): |
|
813d54af8c0c
server (tasks): tasks can now be automatically ran when something happen in a watched dir:
Goffi <goffi@goffi.org>
parents:
1154
diff
changeset
|
138 """Called when an event is received from a watched directory""" |
|
813d54af8c0c
server (tasks): tasks can now be automatically ran when something happen in a watched dir:
Goffi <goffi@goffi.org>
parents:
1154
diff
changeset
|
139 if flags == ['create']: |
|
813d54af8c0c
server (tasks): tasks can now be automatically ran when something happen in a watched dir:
Goffi <goffi@goffi.org>
parents:
1154
diff
changeset
|
140 return |
| 1245 | 141 return defer.ensureDeferred(self.runTask(task_name)) |
|
1155
813d54af8c0c
server (tasks): tasks can now be automatically ran when something happen in a watched dir:
Goffi <goffi@goffi.org>
parents:
1154
diff
changeset
|
142 |
| 1245 | 143 async def runTask(self, task_name): |
|
1155
813d54af8c0c
server (tasks): tasks can now be automatically ran when something happen in a watched dir:
Goffi <goffi@goffi.org>
parents:
1154
diff
changeset
|
144 """Run a single task |
|
813d54af8c0c
server (tasks): tasks can now be automatically ran when something happen in a watched dir:
Goffi <goffi@goffi.org>
parents:
1154
diff
changeset
|
145 |
|
813d54af8c0c
server (tasks): tasks can now be automatically ran when something happen in a watched dir:
Goffi <goffi@goffi.org>
parents:
1154
diff
changeset
|
146 @param task_name(unicode): name of the task to run |
|
813d54af8c0c
server (tasks): tasks can now be automatically ran when something happen in a watched dir:
Goffi <goffi@goffi.org>
parents:
1154
diff
changeset
|
147 """ |
| 1245 | 148 task = self.tasks[task_name] |
|
1155
813d54af8c0c
server (tasks): tasks can now be automatically ran when something happen in a watched dir:
Goffi <goffi@goffi.org>
parents:
1154
diff
changeset
|
149 self._current_task = task_name |
| 1216 | 150 log.info(_('== running task "{task_name}" for {site_name} =='.format( |
|
1155
813d54af8c0c
server (tasks): tasks can now be automatically ran when something happen in a watched dir:
Goffi <goffi@goffi.org>
parents:
1154
diff
changeset
|
151 task_name=task_name, site_name=self.site_name))) |
|
813d54af8c0c
server (tasks): tasks can now be automatically ran when something happen in a watched dir:
Goffi <goffi@goffi.org>
parents:
1154
diff
changeset
|
152 os.chdir(self.site_path) |
|
813d54af8c0c
server (tasks): tasks can now be automatically ran when something happen in a watched dir:
Goffi <goffi@goffi.org>
parents:
1154
diff
changeset
|
153 try: |
| 1245 | 154 await utils.asDeferred(task.start) |
|
1155
813d54af8c0c
server (tasks): tasks can now be automatically ran when something happen in a watched dir:
Goffi <goffi@goffi.org>
parents:
1154
diff
changeset
|
155 except Exception as e: |
| 1245 | 156 on_error = task.ON_ERROR |
| 1216 | 157 if on_error == 'stop': |
|
1155
813d54af8c0c
server (tasks): tasks can now be automatically ran when something happen in a watched dir:
Goffi <goffi@goffi.org>
parents:
1154
diff
changeset
|
158 raise e |
| 1216 | 159 elif on_error == 'continue': |
| 160 log.warning(_('Task "{task_name}" failed for {site_name}: {reason}') | |
|
1155
813d54af8c0c
server (tasks): tasks can now be automatically ran when something happen in a watched dir:
Goffi <goffi@goffi.org>
parents:
1154
diff
changeset
|
161 .format(task_name=task_name, site_name=self.site_name, reason=e)) |
|
813d54af8c0c
server (tasks): tasks can now be automatically ran when something happen in a watched dir:
Goffi <goffi@goffi.org>
parents:
1154
diff
changeset
|
162 else: |
| 1216 | 163 raise exceptions.InternalError("we should never reach this point") |
|
1155
813d54af8c0c
server (tasks): tasks can now be automatically ran when something happen in a watched dir:
Goffi <goffi@goffi.org>
parents:
1154
diff
changeset
|
164 self._current_task = None |
| 1146 | 165 |
| 1245 | 166 async def runTasks(self): |
| 1146 | 167 """Run all the tasks found""" |
| 168 old_path = os.getcwd() | |
| 1216 | 169 for task_name, task_value in self.tasks.items(): |
| 1245 | 170 await self.runTask(task_name) |
| 1146 | 171 os.chdir(old_path) |