view libervia/web/pages/merge-requests/edit/page_meta.py @ 1598:86c7a3a625d5

server: always start a new session on connection: The session was kept when a user was connecting from service profile (but not from other profiles), this was leading to session fixation vulnerability (an attacker on the same machine could get service profile session cookie, and use it when a victim would log-in). This patch fixes it by always starting a new session on connection. fix 443
author Goffi <goffi@goffi.org>
date Fri, 23 Feb 2024 13:35:24 +0100
parents eb00d593801d
children
line wrap: on
line source

#!/usr/bin/env python3


from libervia.web.server.constants import Const as C
from libervia.backend.core.i18n import _
from libervia.backend.tools.common import template_xmlui
from libervia.backend.tools.common import data_format
from libervia.backend.core.log import getLogger

"""merge-requests edition"""

name = "merge-requests_edit"
access = C.PAGES_ACCESS_PROFILE
template = "merge-request/edit.html"
log = getLogger(__name__)


def parse_url(self, request):
    try:
        item_id = self.next_path(request)
    except IndexError:
        log.warning(_("no list item id specified"))
        self.page_error(request, C.HTTP_BAD_REQUEST)

    data = self.get_r_data(request)
    data["list_item_id"] = item_id


async def prepare_render(self, request):
    data = self.get_r_data(request)
    template_data = request.template_data
    service, node, list_item_id = (
        data.get("service", ""),
        data.get("node", ""),
        data["list_item_id"],
    )
    profile = self.get_profile(request)

    ignore = (
        "publisher",
        "author",
        "author_jid",
        "author_email",
        "created",
        "updated",
        "comments_uri",
        "request_data",
        "type",
    )
    merge_requests = data_format.deserialise(
        await self.host.bridge_call(
            "merge_requests_get",
            service.full() if service else "",
            node,
            C.NO_LIMIT,
            [list_item_id],
            "",
            data_format.serialise({}),
            profile,
        )
    )
    list_item = template_xmlui.create(
        self.host, merge_requests['items'][0], ignore=ignore
    )

    try:
        # small trick to get a one line text input instead of the big textarea
        list_item.widgets["labels"].type = "string"
        list_item.widgets["labels"].value = list_item.widgets["labels"].value.replace(
            "\n", ", "
        )
    except KeyError:
        pass

    # same as list_edit
    wid = list_item.widgets['body']
    if wid.type == "xhtmlbox":
        wid.type = "textbox"
        wid.value =  await self.host.bridge_call(
            "syntax_convert", wid.value, C.SYNTAX_XHTML, "markdown",
            False, profile)

    template_data["new_list_item_xmlui"] = list_item


async def on_data_post(self, request):
    data = self.get_r_data(request)
    service = data["service"]
    node = data["node"]
    list_item_id = data["list_item_id"]
    posted_data = self.get_all_posted_data(request)
    if not posted_data["title"] or not posted_data["body"]:
        self.page_error(request, C.HTTP_BAD_REQUEST)
    try:
        posted_data["labels"] = [l.strip() for l in posted_data["labels"][0].split(",")]
    except (KeyError, IndexError):
        pass
    profile = self.get_profile(request)

    # we convert back body to XHTML
    body = await self.host.bridge_call(
        "syntax_convert", posted_data['body'][0], "markdown", C.SYNTAX_XHTML,
        False, profile)
    posted_data['body'] = ['<div xmlns="{ns}">{body}</div>'.format(ns=C.NS_XHTML,
                                                                     body=body)]

    extra = {'update': True}
    await self.host.bridge_call(
        "merge_request_set",
        service.full(),
        node,
        "",
        "auto",
        posted_data,
        "",
        list_item_id,
        data_format.serialise(extra),
        profile,
    )
    # we don't want to redirect to edit page on success, but to list overview
    data["post_redirect_page"] = (
        self.get_page_by_name("merge-requests"),
        service.full(),
        node or "@",
    )