annotate mod_compat_vcard/mod_compat_vcard.lua @ 4651:8231774f5bfd

mod_cloud_notify_encrypted: Ensure body substring remains valid UTF-8 The `body:sub()` call risks splitting the string in the middle of a multi-byte UTF-8 sequence. This should have been caught by util.stanza validation, but that would have caused some havoc, at the very least causing the notification to not be sent. There have been no reports of this happening. Likely because this module isn't widely deployed among users with languages that use many longer UTF-8 sequences. The util.encodings.utf8.valid() function is O(n) where only the last sequence really needs to be checked, but it's in C and expected to be fast.
author Kim Alvefur <zash@zash.se>
date Sun, 22 Aug 2021 13:22:59 +0200
parents 3df303543765
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
749
1a7cdc874b8c mod_compat_vcard: Handle vcard requests sent to full JIDs (a spec violation commited by older versions of ejabberd and possibly others) - replaces vcard_compatibility option from Prosody 0.8
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
1 -- Compatibility with clients and servers (i.e. ejabberd) that send vcard
1a7cdc874b8c mod_compat_vcard: Handle vcard requests sent to full JIDs (a spec violation commited by older versions of ejabberd and possibly others) - replaces vcard_compatibility option from Prosody 0.8
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
2 -- requests to the full JID
1a7cdc874b8c mod_compat_vcard: Handle vcard requests sent to full JIDs (a spec violation commited by older versions of ejabberd and possibly others) - replaces vcard_compatibility option from Prosody 0.8
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
3 --
1a7cdc874b8c mod_compat_vcard: Handle vcard requests sent to full JIDs (a spec violation commited by older versions of ejabberd and possibly others) - replaces vcard_compatibility option from Prosody 0.8
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
4 -- https://support.process-one.net/browse/EJAB-1045
1a7cdc874b8c mod_compat_vcard: Handle vcard requests sent to full JIDs (a spec violation commited by older versions of ejabberd and possibly others) - replaces vcard_compatibility option from Prosody 0.8
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
5
1a7cdc874b8c mod_compat_vcard: Handle vcard requests sent to full JIDs (a spec violation commited by older versions of ejabberd and possibly others) - replaces vcard_compatibility option from Prosody 0.8
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
6 local jid_bare = require "util.jid".bare;
1a7cdc874b8c mod_compat_vcard: Handle vcard requests sent to full JIDs (a spec violation commited by older versions of ejabberd and possibly others) - replaces vcard_compatibility option from Prosody 0.8
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
7 local st = require "util.stanza";
1a7cdc874b8c mod_compat_vcard: Handle vcard requests sent to full JIDs (a spec violation commited by older versions of ejabberd and possibly others) - replaces vcard_compatibility option from Prosody 0.8
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
8 local core_process_stanza = prosody.core_process_stanza;
1a7cdc874b8c mod_compat_vcard: Handle vcard requests sent to full JIDs (a spec violation commited by older versions of ejabberd and possibly others) - replaces vcard_compatibility option from Prosody 0.8
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
9
1a7cdc874b8c mod_compat_vcard: Handle vcard requests sent to full JIDs (a spec violation commited by older versions of ejabberd and possibly others) - replaces vcard_compatibility option from Prosody 0.8
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
10 module:hook("iq/full", function(event)
1a7cdc874b8c mod_compat_vcard: Handle vcard requests sent to full JIDs (a spec violation commited by older versions of ejabberd and possibly others) - replaces vcard_compatibility option from Prosody 0.8
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
11 local stanza = event.stanza;
1a7cdc874b8c mod_compat_vcard: Handle vcard requests sent to full JIDs (a spec violation commited by older versions of ejabberd and possibly others) - replaces vcard_compatibility option from Prosody 0.8
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
12 local payload = stanza.tags[1];
1297
3df303543765 mod_compat_vcard: Fix traceback from probably empty stanzas (Thanks Biszkopcik)
Kim Alvefur <zash@zash.se>
parents: 749
diff changeset
13 if payload and stanza.attr.type == "get" and payload.name == "vCard" and payload.attr.xmlns == "vcard-temp" then
749
1a7cdc874b8c mod_compat_vcard: Handle vcard requests sent to full JIDs (a spec violation commited by older versions of ejabberd and possibly others) - replaces vcard_compatibility option from Prosody 0.8
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
14 local fixed_stanza = st.clone(event.stanza);
1a7cdc874b8c mod_compat_vcard: Handle vcard requests sent to full JIDs (a spec violation commited by older versions of ejabberd and possibly others) - replaces vcard_compatibility option from Prosody 0.8
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
15 fixed_stanza.attr.to = jid_bare(stanza.attr.to);
1a7cdc874b8c mod_compat_vcard: Handle vcard requests sent to full JIDs (a spec violation commited by older versions of ejabberd and possibly others) - replaces vcard_compatibility option from Prosody 0.8
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
16 core_process_stanza(event.origin, fixed_stanza);
1a7cdc874b8c mod_compat_vcard: Handle vcard requests sent to full JIDs (a spec violation commited by older versions of ejabberd and possibly others) - replaces vcard_compatibility option from Prosody 0.8
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
17 return true;
1a7cdc874b8c mod_compat_vcard: Handle vcard requests sent to full JIDs (a spec violation commited by older versions of ejabberd and possibly others) - replaces vcard_compatibility option from Prosody 0.8
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
18 end
1a7cdc874b8c mod_compat_vcard: Handle vcard requests sent to full JIDs (a spec violation commited by older versions of ejabberd and possibly others) - replaces vcard_compatibility option from Prosody 0.8
Matthew Wild <mwild1@gmail.com>
parents:
diff changeset
19 end, 1);