Mercurial > prosody-modules
annotate mod_compat_bind/mod_compat_bind.lua @ 5285:8e1f1eb00b58
mod_sasl2_fast: Fix harmless off-by-one error (invalidates existing tokens!)
Problem:
This was causing the key to become "<token>--cur" instead of the expected
"<token>-cur". As the same key was used by the code to both set and get, it
still worked.
Rationale for change:
Although it worked, it's unintended, inconsistent and messy. It increases the
chances of future bugs due to the unexpected format.
Side-effects of change:
Existing '--cur' entries will not be checked after this change, and therefore
existing FAST clients will fail to authenticate until they attempt password
auth and obtain a new FAST token.
Existing '--cur' entries in storage will not be cleaned up by this commit, but
this is considered a minor issue, and okay for the relatively few FAST
deployments.
author | Matthew Wild <mwild1@gmail.com> |
---|---|
date | Wed, 29 Mar 2023 16:12:15 +0100 |
parents | 73fbfd1e820b |
children |
rev | line source |
---|---|
748
f25b6a9f97bb
mod_compat_bind: Compatibility (ugh) with clients that send the resource bind to the login host (ugh)
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
1 -- Compatibility with clients that set 'to' on resource bind requests |
f25b6a9f97bb
mod_compat_bind: Compatibility (ugh) with clients that send the resource bind to the login host (ugh)
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
2 -- |
f25b6a9f97bb
mod_compat_bind: Compatibility (ugh) with clients that send the resource bind to the login host (ugh)
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
3 -- http://xmpp.org/rfcs/rfc3920.html#bind |
f25b6a9f97bb
mod_compat_bind: Compatibility (ugh) with clients that send the resource bind to the login host (ugh)
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
4 -- http://xmpp.org/rfcs/rfc6120.html#bind-servergen-success |
f25b6a9f97bb
mod_compat_bind: Compatibility (ugh) with clients that send the resource bind to the login host (ugh)
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
5 |
f25b6a9f97bb
mod_compat_bind: Compatibility (ugh) with clients that send the resource bind to the login host (ugh)
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
6 local st = require "util.stanza"; |
f25b6a9f97bb
mod_compat_bind: Compatibility (ugh) with clients that send the resource bind to the login host (ugh)
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
7 |
f25b6a9f97bb
mod_compat_bind: Compatibility (ugh) with clients that send the resource bind to the login host (ugh)
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
8 module:hook("iq/host/urn:ietf:params:xml:ns:xmpp-bind:bind", function(event) |
f25b6a9f97bb
mod_compat_bind: Compatibility (ugh) with clients that send the resource bind to the login host (ugh)
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
9 local fixed_stanza = st.clone(event.stanza); |
f25b6a9f97bb
mod_compat_bind: Compatibility (ugh) with clients that send the resource bind to the login host (ugh)
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
10 fixed_stanza.attr.to = nil; |
2322
73fbfd1e820b
mod_compat_bind: Use non-deprecated way to access core_process_stanza (thanks Roi)
Kim Alvefur <zash@zash.se>
parents:
748
diff
changeset
|
11 prosody.core_process_stanza(event.origin, fixed_stanza); |
748
f25b6a9f97bb
mod_compat_bind: Compatibility (ugh) with clients that send the resource bind to the login host (ugh)
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
12 return true; |
f25b6a9f97bb
mod_compat_bind: Compatibility (ugh) with clients that send the resource bind to the login host (ugh)
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
13 end); |