Mercurial > prosody-modules
annotate mod_compat_dialback/README.markdown @ 5285:8e1f1eb00b58
mod_sasl2_fast: Fix harmless off-by-one error (invalidates existing tokens!)
Problem:
This was causing the key to become "<token>--cur" instead of the expected
"<token>-cur". As the same key was used by the code to both set and get, it
still worked.
Rationale for change:
Although it worked, it's unintended, inconsistent and messy. It increases the
chances of future bugs due to the unexpected format.
Side-effects of change:
Existing '--cur' entries will not be checked after this change, and therefore
existing FAST clients will fail to authenticate until they attempt password
auth and obtain a new FAST token.
Existing '--cur' entries in storage will not be cleaned up by this commit, but
this is considered a minor issue, and okay for the relatively few FAST
deployments.
author | Matthew Wild <mwild1@gmail.com> |
---|---|
date | Wed, 29 Mar 2023 16:12:15 +0100 |
parents | 41ebdb331b94 |
children |
rev | line source |
---|---|
1900
41ebdb331b94
mod_compat_dialback: Workaround for Dialback with servers that violate RFC 6120 § 4.7.2
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
1 --- |
41ebdb331b94
mod_compat_dialback: Workaround for Dialback with servers that violate RFC 6120 § 4.7.2
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
2 summary: Workaround for Dialback with some servers that violate RFC 6120 |
41ebdb331b94
mod_compat_dialback: Workaround for Dialback with servers that violate RFC 6120 § 4.7.2
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
3 ... |
41ebdb331b94
mod_compat_dialback: Workaround for Dialback with servers that violate RFC 6120 § 4.7.2
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
4 |
41ebdb331b94
mod_compat_dialback: Workaround for Dialback with servers that violate RFC 6120 § 4.7.2
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
5 This module provides a workaround for servers that do not set the `to` |
41ebdb331b94
mod_compat_dialback: Workaround for Dialback with servers that violate RFC 6120 § 4.7.2
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
6 attribute on stream headers, which is required per [RFC6120]: |
41ebdb331b94
mod_compat_dialback: Workaround for Dialback with servers that violate RFC 6120 § 4.7.2
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
7 |
41ebdb331b94
mod_compat_dialback: Workaround for Dialback with servers that violate RFC 6120 § 4.7.2
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
8 > ## 4.7.2. to |
41ebdb331b94
mod_compat_dialback: Workaround for Dialback with servers that violate RFC 6120 § 4.7.2
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
9 > |
41ebdb331b94
mod_compat_dialback: Workaround for Dialback with servers that violate RFC 6120 § 4.7.2
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
10 > For initial stream headers in both client-to-server and |
41ebdb331b94
mod_compat_dialback: Workaround for Dialback with servers that violate RFC 6120 § 4.7.2
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
11 > server-to-server communication, the initiating entity MUST include the |
41ebdb331b94
mod_compat_dialback: Workaround for Dialback with servers that violate RFC 6120 § 4.7.2
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
12 > 'to' attribute and MUST set its value to a domainpart that the |
41ebdb331b94
mod_compat_dialback: Workaround for Dialback with servers that violate RFC 6120 § 4.7.2
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
13 > initiating entity knows or expects the receiving entity to service. |
41ebdb331b94
mod_compat_dialback: Workaround for Dialback with servers that violate RFC 6120 § 4.7.2
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
14 |
41ebdb331b94
mod_compat_dialback: Workaround for Dialback with servers that violate RFC 6120 § 4.7.2
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
15 As a side effect of [this issue](https://prosody.im/issues/issue/285), |
41ebdb331b94
mod_compat_dialback: Workaround for Dialback with servers that violate RFC 6120 § 4.7.2
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
16 Prosody 0.10 will be unable to do [Dialback][xep220] with servers that |
41ebdb331b94
mod_compat_dialback: Workaround for Dialback with servers that violate RFC 6120 § 4.7.2
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
17 don't follow this. |
41ebdb331b94
mod_compat_dialback: Workaround for Dialback with servers that violate RFC 6120 § 4.7.2
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
18 |
41ebdb331b94
mod_compat_dialback: Workaround for Dialback with servers that violate RFC 6120 § 4.7.2
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
19 # Known servers affected |
41ebdb331b94
mod_compat_dialback: Workaround for Dialback with servers that violate RFC 6120 § 4.7.2
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
20 |
41ebdb331b94
mod_compat_dialback: Workaround for Dialback with servers that violate RFC 6120 § 4.7.2
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
21 * Openfire 3.10.2 (and probably earlier versions) |