Mercurial > prosody-modules
annotate mod_compat_vcard/mod_compat_vcard.lua @ 5285:8e1f1eb00b58
mod_sasl2_fast: Fix harmless off-by-one error (invalidates existing tokens!)
Problem:
This was causing the key to become "<token>--cur" instead of the expected
"<token>-cur". As the same key was used by the code to both set and get, it
still worked.
Rationale for change:
Although it worked, it's unintended, inconsistent and messy. It increases the
chances of future bugs due to the unexpected format.
Side-effects of change:
Existing '--cur' entries will not be checked after this change, and therefore
existing FAST clients will fail to authenticate until they attempt password
auth and obtain a new FAST token.
Existing '--cur' entries in storage will not be cleaned up by this commit, but
this is considered a minor issue, and okay for the relatively few FAST
deployments.
author | Matthew Wild <mwild1@gmail.com> |
---|---|
date | Wed, 29 Mar 2023 16:12:15 +0100 |
parents | 3df303543765 |
children |
rev | line source |
---|---|
749
1a7cdc874b8c
mod_compat_vcard: Handle vcard requests sent to full JIDs (a spec violation commited by older versions of ejabberd and possibly others) - replaces vcard_compatibility option from Prosody 0.8
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
1 -- Compatibility with clients and servers (i.e. ejabberd) that send vcard |
1a7cdc874b8c
mod_compat_vcard: Handle vcard requests sent to full JIDs (a spec violation commited by older versions of ejabberd and possibly others) - replaces vcard_compatibility option from Prosody 0.8
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
2 -- requests to the full JID |
1a7cdc874b8c
mod_compat_vcard: Handle vcard requests sent to full JIDs (a spec violation commited by older versions of ejabberd and possibly others) - replaces vcard_compatibility option from Prosody 0.8
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
3 -- |
1a7cdc874b8c
mod_compat_vcard: Handle vcard requests sent to full JIDs (a spec violation commited by older versions of ejabberd and possibly others) - replaces vcard_compatibility option from Prosody 0.8
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
4 -- https://support.process-one.net/browse/EJAB-1045 |
1a7cdc874b8c
mod_compat_vcard: Handle vcard requests sent to full JIDs (a spec violation commited by older versions of ejabberd and possibly others) - replaces vcard_compatibility option from Prosody 0.8
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
5 |
1a7cdc874b8c
mod_compat_vcard: Handle vcard requests sent to full JIDs (a spec violation commited by older versions of ejabberd and possibly others) - replaces vcard_compatibility option from Prosody 0.8
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
6 local jid_bare = require "util.jid".bare; |
1a7cdc874b8c
mod_compat_vcard: Handle vcard requests sent to full JIDs (a spec violation commited by older versions of ejabberd and possibly others) - replaces vcard_compatibility option from Prosody 0.8
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
7 local st = require "util.stanza"; |
1a7cdc874b8c
mod_compat_vcard: Handle vcard requests sent to full JIDs (a spec violation commited by older versions of ejabberd and possibly others) - replaces vcard_compatibility option from Prosody 0.8
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
8 local core_process_stanza = prosody.core_process_stanza; |
1a7cdc874b8c
mod_compat_vcard: Handle vcard requests sent to full JIDs (a spec violation commited by older versions of ejabberd and possibly others) - replaces vcard_compatibility option from Prosody 0.8
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
9 |
1a7cdc874b8c
mod_compat_vcard: Handle vcard requests sent to full JIDs (a spec violation commited by older versions of ejabberd and possibly others) - replaces vcard_compatibility option from Prosody 0.8
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
10 module:hook("iq/full", function(event) |
1a7cdc874b8c
mod_compat_vcard: Handle vcard requests sent to full JIDs (a spec violation commited by older versions of ejabberd and possibly others) - replaces vcard_compatibility option from Prosody 0.8
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
11 local stanza = event.stanza; |
1a7cdc874b8c
mod_compat_vcard: Handle vcard requests sent to full JIDs (a spec violation commited by older versions of ejabberd and possibly others) - replaces vcard_compatibility option from Prosody 0.8
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
12 local payload = stanza.tags[1]; |
1297
3df303543765
mod_compat_vcard: Fix traceback from probably empty stanzas (Thanks Biszkopcik)
Kim Alvefur <zash@zash.se>
parents:
749
diff
changeset
|
13 if payload and stanza.attr.type == "get" and payload.name == "vCard" and payload.attr.xmlns == "vcard-temp" then |
749
1a7cdc874b8c
mod_compat_vcard: Handle vcard requests sent to full JIDs (a spec violation commited by older versions of ejabberd and possibly others) - replaces vcard_compatibility option from Prosody 0.8
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
14 local fixed_stanza = st.clone(event.stanza); |
1a7cdc874b8c
mod_compat_vcard: Handle vcard requests sent to full JIDs (a spec violation commited by older versions of ejabberd and possibly others) - replaces vcard_compatibility option from Prosody 0.8
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
15 fixed_stanza.attr.to = jid_bare(stanza.attr.to); |
1a7cdc874b8c
mod_compat_vcard: Handle vcard requests sent to full JIDs (a spec violation commited by older versions of ejabberd and possibly others) - replaces vcard_compatibility option from Prosody 0.8
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
16 core_process_stanza(event.origin, fixed_stanza); |
1a7cdc874b8c
mod_compat_vcard: Handle vcard requests sent to full JIDs (a spec violation commited by older versions of ejabberd and possibly others) - replaces vcard_compatibility option from Prosody 0.8
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
17 return true; |
1a7cdc874b8c
mod_compat_vcard: Handle vcard requests sent to full JIDs (a spec violation commited by older versions of ejabberd and possibly others) - replaces vcard_compatibility option from Prosody 0.8
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
18 end |
1a7cdc874b8c
mod_compat_vcard: Handle vcard requests sent to full JIDs (a spec violation commited by older versions of ejabberd and possibly others) - replaces vcard_compatibility option from Prosody 0.8
Matthew Wild <mwild1@gmail.com>
parents:
diff
changeset
|
19 end, 1); |