Mercurial > prosody-modules
annotate mod_measure_registration/mod_measure_registration.lua @ 5285:8e1f1eb00b58
mod_sasl2_fast: Fix harmless off-by-one error (invalidates existing tokens!)
Problem:
This was causing the key to become "<token>--cur" instead of the expected
"<token>-cur". As the same key was used by the code to both set and get, it
still worked.
Rationale for change:
Although it worked, it's unintended, inconsistent and messy. It increases the
chances of future bugs due to the unexpected format.
Side-effects of change:
Existing '--cur' entries will not be checked after this change, and therefore
existing FAST clients will fail to authenticate until they attempt password
auth and obtain a new FAST token.
Existing '--cur' entries in storage will not be cleaned up by this commit, but
this is considered a minor issue, and okay for the relatively few FAST
deployments.
author | Matthew Wild <mwild1@gmail.com> |
---|---|
date | Wed, 29 Mar 2023 16:12:15 +0100 |
parents | 32d9d155a9b9 |
children |
rev | line source |
---|---|
3951
32d9d155a9b9
mod_measure_registration: new module
Maxime “pep” Buquet <pep@bouah.net>
parents:
diff
changeset
|
1 local count_registering = module:measure("user_registering", "rate"); |
32d9d155a9b9
mod_measure_registration: new module
Maxime “pep” Buquet <pep@bouah.net>
parents:
diff
changeset
|
2 local count_registered = module:measure("user_registered", "rate"); |
32d9d155a9b9
mod_measure_registration: new module
Maxime “pep” Buquet <pep@bouah.net>
parents:
diff
changeset
|
3 |
32d9d155a9b9
mod_measure_registration: new module
Maxime “pep” Buquet <pep@bouah.net>
parents:
diff
changeset
|
4 module:hook("user-registering", function () |
32d9d155a9b9
mod_measure_registration: new module
Maxime “pep” Buquet <pep@bouah.net>
parents:
diff
changeset
|
5 count_registering(); |
32d9d155a9b9
mod_measure_registration: new module
Maxime “pep” Buquet <pep@bouah.net>
parents:
diff
changeset
|
6 end); |
32d9d155a9b9
mod_measure_registration: new module
Maxime “pep” Buquet <pep@bouah.net>
parents:
diff
changeset
|
7 |
32d9d155a9b9
mod_measure_registration: new module
Maxime “pep” Buquet <pep@bouah.net>
parents:
diff
changeset
|
8 module:hook("user-registered", function () |
32d9d155a9b9
mod_measure_registration: new module
Maxime “pep” Buquet <pep@bouah.net>
parents:
diff
changeset
|
9 count_registered(); |
32d9d155a9b9
mod_measure_registration: new module
Maxime “pep” Buquet <pep@bouah.net>
parents:
diff
changeset
|
10 end); |