Mercurial > prosody-modules
annotate mod_muc_gc10/README.markdown @ 5285:8e1f1eb00b58
mod_sasl2_fast: Fix harmless off-by-one error (invalidates existing tokens!)
Problem:
This was causing the key to become "<token>--cur" instead of the expected
"<token>-cur". As the same key was used by the code to both set and get, it
still worked.
Rationale for change:
Although it worked, it's unintended, inconsistent and messy. It increases the
chances of future bugs due to the unexpected format.
Side-effects of change:
Existing '--cur' entries will not be checked after this change, and therefore
existing FAST clients will fail to authenticate until they attempt password
auth and obtain a new FAST token.
Existing '--cur' entries in storage will not be cleaned up by this commit, but
this is considered a minor issue, and okay for the relatively few FAST
deployments.
author | Matthew Wild <mwild1@gmail.com> |
---|---|
date | Wed, 29 Mar 2023 16:12:15 +0100 |
parents | 0167a102ed35 |
children |
rev | line source |
---|---|
2940
0167a102ed35
mod_muc_gc10: Gather statistics on use of the Groupchat 1.0 protocol
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
1 # Groupchat 1.0 usage statistics gathering |
0167a102ed35
mod_muc_gc10: Gather statistics on use of the Groupchat 1.0 protocol
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
2 |
0167a102ed35
mod_muc_gc10: Gather statistics on use of the Groupchat 1.0 protocol
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
3 Groupchat 1.0 was probably the protocol that predated |
0167a102ed35
mod_muc_gc10: Gather statistics on use of the Groupchat 1.0 protocol
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
4 [XEP-0045: Multi-User Chat] and there is still some compatibility that |
0167a102ed35
mod_muc_gc10: Gather statistics on use of the Groupchat 1.0 protocol
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
5 lives on, in the XEP and in implementations. |
0167a102ed35
mod_muc_gc10: Gather statistics on use of the Groupchat 1.0 protocol
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
6 |
0167a102ed35
mod_muc_gc10: Gather statistics on use of the Groupchat 1.0 protocol
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
7 This module tries to detect clients still using the GC 1.0 protocol and |
0167a102ed35
mod_muc_gc10: Gather statistics on use of the Groupchat 1.0 protocol
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
8 what software they run, to determine if support can be removed. |
0167a102ed35
mod_muc_gc10: Gather statistics on use of the Groupchat 1.0 protocol
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
9 |
0167a102ed35
mod_muc_gc10: Gather statistics on use of the Groupchat 1.0 protocol
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
10 Since joins in the GC 1.0 protocol are highly ambiguous, some hits |
0167a102ed35
mod_muc_gc10: Gather statistics on use of the Groupchat 1.0 protocol
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
11 reported will be because of desynchronized MUC clients |
0167a102ed35
mod_muc_gc10: Gather statistics on use of the Groupchat 1.0 protocol
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
12 |
0167a102ed35
mod_muc_gc10: Gather statistics on use of the Groupchat 1.0 protocol
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
13 # Compatibility |
0167a102ed35
mod_muc_gc10: Gather statistics on use of the Groupchat 1.0 protocol
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
14 |
0167a102ed35
mod_muc_gc10: Gather statistics on use of the Groupchat 1.0 protocol
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
15 Should work with Prosody 0.10.x and earlier. |
0167a102ed35
mod_muc_gc10: Gather statistics on use of the Groupchat 1.0 protocol
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
16 |
0167a102ed35
mod_muc_gc10: Gather statistics on use of the Groupchat 1.0 protocol
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
17 It will not work with current trunk, since the MUC code has had major |
0167a102ed35
mod_muc_gc10: Gather statistics on use of the Groupchat 1.0 protocol
Kim Alvefur <zash@zash.se>
parents:
diff
changeset
|
18 changes. |