annotate mod_s2s_smacks_timeout/mod_s2s_smacks_timeout.lua @ 5285:8e1f1eb00b58

mod_sasl2_fast: Fix harmless off-by-one error (invalidates existing tokens!) Problem: This was causing the key to become "<token>--cur" instead of the expected "<token>-cur". As the same key was used by the code to both set and get, it still worked. Rationale for change: Although it worked, it's unintended, inconsistent and messy. It increases the chances of future bugs due to the unexpected format. Side-effects of change: Existing '--cur' entries will not be checked after this change, and therefore existing FAST clients will fail to authenticate until they attempt password auth and obtain a new FAST token. Existing '--cur' entries in storage will not be cleaned up by this commit, but this is considered a minor issue, and okay for the relatively few FAST deployments.
author Matthew Wild <mwild1@gmail.com>
date Wed, 29 Mar 2023 16:12:15 +0100
parents f0fe95f9e21c
children
Ignore whitespace changes - Everywhere: Within whitespace: At end of lines:
rev   line source
4981
f0fe95f9e21c mod_s2s_smacks_timeout: Use mod_smacks to close stale s2s connections
Kim Alvefur <zash@zash.se>
parents:
diff changeset
1 module:depends("smacks");
f0fe95f9e21c mod_s2s_smacks_timeout: Use mod_smacks to close stale s2s connections
Kim Alvefur <zash@zash.se>
parents:
diff changeset
2
f0fe95f9e21c mod_s2s_smacks_timeout: Use mod_smacks to close stale s2s connections
Kim Alvefur <zash@zash.se>
parents:
diff changeset
3 module:hook("smacks-ack-delayed", function (event)
f0fe95f9e21c mod_s2s_smacks_timeout: Use mod_smacks to close stale s2s connections
Kim Alvefur <zash@zash.se>
parents:
diff changeset
4 if event.origin.type == "s2sin" or event.origin.type == "s2sout" then
f0fe95f9e21c mod_s2s_smacks_timeout: Use mod_smacks to close stale s2s connections
Kim Alvefur <zash@zash.se>
parents:
diff changeset
5 event.origin:close("connection-timeout");
f0fe95f9e21c mod_s2s_smacks_timeout: Use mod_smacks to close stale s2s connections
Kim Alvefur <zash@zash.se>
parents:
diff changeset
6 return true;
f0fe95f9e21c mod_s2s_smacks_timeout: Use mod_smacks to close stale s2s connections
Kim Alvefur <zash@zash.se>
parents:
diff changeset
7 end
f0fe95f9e21c mod_s2s_smacks_timeout: Use mod_smacks to close stale s2s connections
Kim Alvefur <zash@zash.se>
parents:
diff changeset
8 end);