Mercurial > prosody-modules

diff mod_tcpproxy/mod_tcpproxy.lua @ 153:31e24026e4fd

Find changesets by keywords (author, files, the commit message), revision number or hash, or revset expression.
mod_tcpproxy: Handle gracefully invalid base64 data, fixes #2 (thanks dersd)
author Matthew Wild <mwild1@gmail.com>
date Wed, 19 May 2010 14:02:19 +0100
parents 4db80a46b064
children 07c1c3eaf0c4
line wrap: on
line diff
--- a/mod_tcpproxy/mod_tcpproxy.lua	Sat May 15 23:05:53 2010 +0500
+++ b/mod_tcpproxy/mod_tcpproxy.lua	Wed May 19 14:02:19 2010 +0100
@@ -84,7 +84,14 @@
 	elseif ibb_tag.name == "data" then
 		local conn = open_connections[stanza.attr.from][ibb_tag.attr.sid];
 		if conn then
-			conn:write(unb64(ibb_tag:get_text()));
+			local data = unb64(ibb_tag:get_text());
+			if data then
+				conn:write(data);
+			else
+				return origin.send(
+					st.error_reply(stanza, "modify", "bad-request", "Invalid data (base64?)")
+				);
+			end
 		else
 			return origin.send(st.error_reply(stanza, "cancel", "item-not-found"));
 		end