Mercurial > prosody-modules
diff mod_http_oauth2/html/consent.html @ 5418:f2c7bb3af600
mod_http_oauth2: Add role selector to consent page
List includes all roles available to the user, if more than one.
Defaults to either the first role in the scope string or the users
primary role.
Earlier draft listed all roles, but having options that can't be
selected is bad UX and the entire list of all roles on the server could
be long, and perhaps even sensitive.
Allows e.g. picking a role with fewer permissions than what might
otherwise have been selected.
UX wise, doing this with more checkboxes or possibly radio buttons would
have been confusion and/or looked messier.
Fixes the previous situation where unselecting a role would default to
the primary role, which could be more permissions than requested.
| author | Kim Alvefur <zash@zash.se> |
|---|---|
| date | Fri, 05 May 2023 01:23:13 +0200 |
| parents | 3a1df3adad0c |
| children | b45d9a81b3da |
line wrap: on
line diff
--- a/mod_http_oauth2/html/consent.html Fri May 05 00:57:20 2023 +0200 +++ b/mod_http_oauth2/html/consent.html Fri May 05 01:23:13 2023 +0200 @@ -38,7 +38,10 @@ <form method="post"> <details><summary>Requested permissions</summary>{scopes# - <input class="scope" type="checkbox" id="scope_{idx}" name="scope" value="{item}" checked><label class="scope" for="scope_{idx}">{item}</label>} + <input class="scope" type="checkbox" id="scope_{idx}" name="scope" value="{item}" checked><label class="scope" for="scope_{idx}">{item}</label>}{roles& + <select name="role">{roles# + <option value="{item.name}"{item.selected& selected}>{item.name}</option>} + </select>} </details> <input type="hidden" name="user_token" value="{state.user.token}"> <button type="submit" name="consent" value="denied">Deny</button>