Mercurial > prosody-modules
view mod_graceful_shutdown/README.markdown @ 4651:8231774f5bfd
mod_cloud_notify_encrypted: Ensure body substring remains valid UTF-8
The `body:sub()` call risks splitting the string in the middle of a
multi-byte UTF-8 sequence. This should have been caught by util.stanza
validation, but that would have caused some havoc, at the very least causing
the notification to not be sent.
There have been no reports of this happening. Likely because this module
isn't widely deployed among users with languages that use many longer UTF-8
sequences.
The util.encodings.utf8.valid() function is O(n) where only the last
sequence really needs to be checked, but it's in C and expected to be fast.
author | Kim Alvefur <zash@zash.se> |
---|---|
date | Sun, 22 Aug 2021 13:22:59 +0200 |
parents | 88474dd1af48 |
children | 999e7cb7f6d9 |
line wrap: on
line source
This module is an experiment about a more graceful shutdown process. Why === When shutting down, a number of sessions, connections and other things are teared down. Due to all these things happening very quickly, sometimes e.g. client unavailable notifications don't make it to all remote contacts because the server-to-server connections are teared down just after. How === This module works by breaking the shutdown process into separate steps with a brief pause between them. It goes something like this 1. Stop accepting new client connections. 2. Close all client connections. 3. Fire event for everything else. 4. Tell `net.server` to quit the main loop. 5. ??? 6. Still here? Kill itself.