Mercurial > prosody-modules
view mod_http_rest/mod_http_rest.lua @ 4651:8231774f5bfd
mod_cloud_notify_encrypted: Ensure body substring remains valid UTF-8
The `body:sub()` call risks splitting the string in the middle of a
multi-byte UTF-8 sequence. This should have been caught by util.stanza
validation, but that would have caused some havoc, at the very least causing
the notification to not be sent.
There have been no reports of this happening. Likely because this module
isn't widely deployed among users with languages that use many longer UTF-8
sequences.
The util.encodings.utf8.valid() function is O(n) where only the last
sequence really needs to be checked, but it's in C and expected to be fast.
author | Kim Alvefur <zash@zash.se> |
---|---|
date | Sun, 22 Aug 2021 13:22:59 +0200 |
parents | 79432b859d21 |
children |
line wrap: on
line source
module:depends"http" local jid_split = require "util.jid".split; local jid_prep = require "util.jid".prep; local stanza = require "util.stanza"; local test_password = require "core.usermanager".test_password; local b64_decode = require "util.encodings".base64.decode; local formdecode = require "net.http".formdecode; local xml = require"util.xml"; local function handle_post(event, path, authed_user) local request = event.request; local headers = request.headers; local body_type = headers.content_type; if body_type == "text/xml" and request.body then local parsed, err = xml.parse(request.body); if parsed then module:log("debug", "Sending %s", parsed); module:send(parsed); return 201; end else return 415; end return 422; end module:provides("http", { default_path = "/rest"; route = { ["POST"] = handle_post; OPTIONS = function(e) local headers = e.response.headers; headers.allow = "POST"; headers.accept = "test/xml"; return 200; end; } });