Mercurial > prosody-modules
view mod_default_vcard/mod_default_vcard.lua @ 5285:8e1f1eb00b58
mod_sasl2_fast: Fix harmless off-by-one error (invalidates existing tokens!)
Problem:
This was causing the key to become "<token>--cur" instead of the expected
"<token>-cur". As the same key was used by the code to both set and get, it
still worked.
Rationale for change:
Although it worked, it's unintended, inconsistent and messy. It increases the
chances of future bugs due to the unexpected format.
Side-effects of change:
Existing '--cur' entries will not be checked after this change, and therefore
existing FAST clients will fail to authenticate until they attempt password
auth and obtain a new FAST token.
Existing '--cur' entries in storage will not be cleaned up by this commit, but
this is considered a minor issue, and okay for the relatively few FAST
deployments.
author | Matthew Wild <mwild1@gmail.com> |
---|---|
date | Wed, 29 Mar 2023 16:12:15 +0100 |
parents | 7236cdec3ea1 |
children |
line wrap: on
line source
local datamanager = require "util.datamanager"; local st = require "util.stanza"; local host = module.host; module:hook("user-registered", function(event) local username = event.username; local data = datamanager.load(username, host, "account_details"); local vcard = datamanager.load(username, host, "vcard"); --module:log("debug", "Has account details: %s", data and "yes" or "no"); --module:log("debug", "Has vCard: %s", vcard and "yes" or "no"); if data and not vcard then local name, first, last = data.name, data.first, data.last; if not name and (first and last) then name = first .. " " .. last; elseif name and not (first and last) then first, last = name:match("^(%w+)%s+(%w+)$") end local vcard = st.stanza("vCard", { xmlns = "vcard-temp" }) :tag("VERSION"):text("3.0"):up(); if first or last then vcard:tag("N") :tag("FAMILY"):text(last or ""):up() :tag("GIVEN"):text(first or ""):up() :up() end if name then vcard:tag("FN"):text(name or ""):up() end vcard:tag("NICKNAME"):text(data.nick or username):up(); if data.email then vcard:tag("EMAIL"):tag("USERID"):text(data.email):up():up(); end local ok, err = datamanager.store(username, host, "vcard", st.preserialize(vcard)); if not ok then module:log("error", "Couldn't save vCard data, %s", err); end end end);