Mercurial > prosody-modules
view mod_graceful_shutdown/README.markdown @ 5285:8e1f1eb00b58
mod_sasl2_fast: Fix harmless off-by-one error (invalidates existing tokens!)
Problem:
This was causing the key to become "<token>--cur" instead of the expected
"<token>-cur". As the same key was used by the code to both set and get, it
still worked.
Rationale for change:
Although it worked, it's unintended, inconsistent and messy. It increases the
chances of future bugs due to the unexpected format.
Side-effects of change:
Existing '--cur' entries will not be checked after this change, and therefore
existing FAST clients will fail to authenticate until they attempt password
auth and obtain a new FAST token.
Existing '--cur' entries in storage will not be cleaned up by this commit, but
this is considered a minor issue, and okay for the relatively few FAST
deployments.
| author | Matthew Wild <mwild1@gmail.com> |
|---|---|
| date | Wed, 29 Mar 2023 16:12:15 +0100 |
| parents | 999e7cb7f6d9 |
| children |
line wrap: on
line source
::: {.alert .alert-warning} This module is an experiment about a more graceful shutdown process. Graceful shutdown has now been implemented in Prosody trunk and will be part 0.12. See [issue #1225](https://issues.prosody.im/1225) for details. ::: Why === When shutting down, a number of sessions, connections and other things are teared down. Due to all these things happening very quickly, sometimes e.g. client unavailable notifications don't make it to all remote contacts because the server-to-server connections are teared down just after. How === This module works by breaking the shutdown process into separate steps with a brief pause between them. It goes something like this 1. Stop accepting new client connections. 2. Close all client connections. 3. Fire event for everything else. 4. Tell `net.server` to quit the main loop. 5. ??? 6. Still here? Kill itself.