Mercurial > prosody-modules
view mod_groups_migration/mod_groups_migration.lua @ 5285:8e1f1eb00b58
mod_sasl2_fast: Fix harmless off-by-one error (invalidates existing tokens!)
Problem:
This was causing the key to become "<token>--cur" instead of the expected
"<token>-cur". As the same key was used by the code to both set and get, it
still worked.
Rationale for change:
Although it worked, it's unintended, inconsistent and messy. It increases the
chances of future bugs due to the unexpected format.
Side-effects of change:
Existing '--cur' entries will not be checked after this change, and therefore
existing FAST clients will fail to authenticate until they attempt password
auth and obtain a new FAST token.
Existing '--cur' entries in storage will not be cleaned up by this commit, but
this is considered a minor issue, and okay for the relatively few FAST
deployments.
author | Matthew Wild <mwild1@gmail.com> |
---|---|
date | Wed, 29 Mar 2023 16:12:15 +0100 |
parents | dd3bfe8f182e |
children |
line wrap: on
line source
local host = module.host; local usermanager = require"core.usermanager"; local mod_groups = module:depends("groups_internal"); local default_group_id = module:get_option("group_default_id", "default"); local default_group_name = module:get_option("group_default_name", "default"); local function trigger_migration() if mod_groups.exists(default_group_id) then module:log("debug", "skipping migration, group exists already") return end module:log("info", "migrating to mod_groups!") local group_id = default_group_id; local ok, err = mod_groups.create({name=default_group_name}, true, group_id); if not ok then module:log("error", "failed to create group: %s", err) return end for user in usermanager.users(host) do mod_groups.add_member(group_id, user, true); module:log("debug", "added %s to %s", user, group_id) end module:log("debug", "synchronising group %s", group_id) mod_groups.sync(group_id) module:log("info", "added all users to group %s", group_id) end module:hook_global("server-started", trigger_migration, -100)