Mercurial > prosody-modules
view mod_groups_shell/mod_groups_shell.lua @ 5285:8e1f1eb00b58
mod_sasl2_fast: Fix harmless off-by-one error (invalidates existing tokens!)
Problem:
This was causing the key to become "<token>--cur" instead of the expected
"<token>-cur". As the same key was used by the code to both set and get, it
still worked.
Rationale for change:
Although it worked, it's unintended, inconsistent and messy. It increases the
chances of future bugs due to the unexpected format.
Side-effects of change:
Existing '--cur' entries will not be checked after this change, and therefore
existing FAST clients will fail to authenticate until they attempt password
auth and obtain a new FAST token.
Existing '--cur' entries in storage will not be cleaned up by this commit, but
this is considered a minor issue, and okay for the relatively few FAST
deployments.
author | Matthew Wild <mwild1@gmail.com> |
---|---|
date | Wed, 29 Mar 2023 16:12:15 +0100 |
parents | 8b69e0b56db2 |
children |
line wrap: on
line source
module:set_global() local modulemanager = require "core.modulemanager"; local shell_env = module:shared("/*/admin_shell/env") shell_env.groups = {}; function shell_env.groups:sync_group(host, group_id) local print = self.session.print; if not host then return false, "host not given" end local mod_groups = modulemanager.get_module(host, "groups_internal") if not mod_groups then return false, host .. " does not have mod_groups_internal loaded" end if not group_id then return false, "group id not given" end local ok, err = mod_groups.emit_member_events(group_id) if ok then return true, "Synchronised members" else return ok, err end end