Mercurial > prosody-modules
view mod_http_stats_stream/mod_http_stats_stream.lua @ 5285:8e1f1eb00b58
mod_sasl2_fast: Fix harmless off-by-one error (invalidates existing tokens!)
Problem:
This was causing the key to become "<token>--cur" instead of the expected
"<token>-cur". As the same key was used by the code to both set and get, it
still worked.
Rationale for change:
Although it worked, it's unintended, inconsistent and messy. It increases the
chances of future bugs due to the unexpected format.
Side-effects of change:
Existing '--cur' entries will not be checked after this change, and therefore
existing FAST clients will fail to authenticate until they attempt password
auth and obtain a new FAST token.
Existing '--cur' entries in storage will not be cleaned up by this commit, but
this is considered a minor issue, and okay for the relatively few FAST
deployments.
author | Matthew Wild <mwild1@gmail.com> |
---|---|
date | Wed, 29 Mar 2023 16:12:15 +0100 |
parents | bac3dae031ee |
children |
line wrap: on
line source
module:set_global(); local statsman = require "core.statsmanager"; local http = require "net.http.server"; local json = require "util.json"; assert(statsman.get_stats, "not compatible with trunk based on openmetrics"); local sessions = {}; local function updates_client_closed(response) module:log("debug", "Streamstats client closed"); sessions[response] = nil; end local function get_updates(event) local request, response = event.request, event.response; response.on_destroy = updates_client_closed; response.headers.content_type = "text/event-stream"; response.headers.x_accel_buffering = "no"; -- for nginx maybe? local resp = http.prepare_header(response); table.insert(resp, "event: stats-full\r\n"); table.insert(resp, "data: "); table.insert(resp, json.encode(statsman.get_stats())); table.insert(resp, "\r\n\r\n"); response.conn:write(table.concat(resp)); sessions[response] = request; return true; end module:hook("stats-updated", function (event) local data = table.concat({ "event: stats-updated"; "data: "..json.encode(event.changed_stats); ""; ""; }, "\r\n") for response in pairs(sessions) do response.conn:write(data); end end); module:depends("http"); module:provides("http", { route = { GET = get_updates; } });