Mercurial > prosody-modules
view mod_jid_prep/mod_jid_prep.lua @ 5285:8e1f1eb00b58
mod_sasl2_fast: Fix harmless off-by-one error (invalidates existing tokens!)
Problem:
This was causing the key to become "<token>--cur" instead of the expected
"<token>-cur". As the same key was used by the code to both set and get, it
still worked.
Rationale for change:
Although it worked, it's unintended, inconsistent and messy. It increases the
chances of future bugs due to the unexpected format.
Side-effects of change:
Existing '--cur' entries will not be checked after this change, and therefore
existing FAST clients will fail to authenticate until they attempt password
auth and obtain a new FAST token.
Existing '--cur' entries in storage will not be cleaned up by this commit, but
this is considered a minor issue, and okay for the relatively few FAST
deployments.
author | Matthew Wild <mwild1@gmail.com> |
---|---|
date | Wed, 29 Mar 2023 16:12:15 +0100 |
parents | 99cb06b31ae8 |
children |
line wrap: on
line source
-- Run JIDs through stringprep processing on behalf of clients -- http://xmpp.org/extensions/inbox/jidprep.html local jid_prep = require "util.jid".prep; local st = require "util.stanza"; local xmlns_prep = "urn:xmpp:jidprep:0"; module:add_feature(xmlns_prep); function prep_jid(event) local stanza = event.stanza; local jid = jid_prep(stanza:get_child_text("jid", xmlns_prep)); if not jid then return event.origin.send(st.error_reply(stanza, "modify", "jid-malformed")); end return event.origin.send(st.reply(stanza):tag("jid", { xmlns = xmlns_prep }):text(jid)); end module:hook("iq/host/"..xmlns_prep..":jid", prep_jid); module:depends("http"); module:provides("http", { route = { ["GET /*"] = function (event, jid) return jid_prep(jid) or 400; end; } });